Closed Bug 1824220 Opened 1 year ago Closed 1 month ago

Add support for "beforeunload" simple prompts

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
5

Tracking

(firefox129 fixed)

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 6 open bugs,
URL
)

Details

(Whiteboard: [webdriver:m11], [wptsync upstream])

Attachments

(3 files)

Bug 1824220 - [webdriver-bidi] Add support for "beforeunload" prompts.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1824220 - [wdspec] Add BiDi tests for beforeunload prompts.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1824220 - [geckoview] Return promptType in details for DOMModalDialogClosed event.
48 bytes, text/x-phabricator-request
Details | Review

With bug 1824197 we will get support for simple dialogs like alert, prompt, and confirm.

But we also have to support beforeunload prompts. Before we can add support for those prompts we will have to fix bug 1693857 for Marionette which currently completely disabled these type of prompts.

Summary: Add support for "browsingContext.handleUserPrompt" command → Add support for "beforeunload" simple prompts to "browsingContext.handleUserPrompt" command

Actually this would also require us to add support for both the browsingContext.userPromptOpened and browsingContext.userPromptClosed events as well. So lets wait for their initial implementation first.

Blocks: 1775280, 1775279
Depends on: 1824221, 1824224
Summary: Add support for "beforeunload" simple prompts to "browsingContext.handleUserPrompt" command → Add support for "beforeunload" simple prompts
Priority: -- → P3
Whiteboard: [webdriver:backlog]
Whiteboard: [webdriver:backlog] → [webdriver:m10]
Points: --- → 3
Priority: P3 → P2
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Whiteboard: [webdriver:m10] → [webdriver:m11]

This bug is currently still blocked.

Assignee: hskupin → nobody
Status: ASSIGNED → NEW
Whiteboard: [webdriver:m11] → [webdriver:m11:blocked]
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
See Also: https://github.com/w3c/webdriver/pull/1791 → https://github.com/w3c/webdriver-bidi/pull/681
Whiteboard: [webdriver:m11:blocked] → [webdriver:m11]

We are going to ignore the Android TestRunner support for now, and we can add that later.

No longer depends on: 1879324
No longer blocks: 1862380
Depends on: 1862380
Attachment #9376184 - Attachment description: WIP: Bug 1824220 - [webdriver-bidi] Add support for "beforeunload" prompts. → Bug 1824220 - [webdriver-bidi] Add support for "beforeunload" prompts.
Attachment #9376185 - Attachment description: WIP: Bug 1824220 - [wdspec] Add BiDi tests for beforeunload prompts. → Bug 1824220 - [wdspec] Add BiDi tests for beforeunload prompts.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/989f4619897b
[geckoview] Return promptType in details for DOMModalDialogClosed event. r=ohall,geckoview-reviewers
https://hg.mozilla.org/integration/autoland/rev/6393df0d4ce1
[webdriver-bidi] Add support for "beforeunload" prompts. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/6c4ce197ba26
[wdspec] Add BiDi tests for beforeunload prompts. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46808 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m11] → [webdriver:m11], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/989f4619897b
https://hg.mozilla.org/mozilla-central/rev/6393df0d4ce1
https://hg.mozilla.org/mozilla-central/rev/6c4ce197ba26

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.