Closed Bug 1884090 Opened 5 months ago Closed 2 months ago

Add support for "HTTP flag" in WebDriver Session

Categories

(Remote Protocol :: Agent, task, P2)

task
Points:
3

Tracking

(firefox128 fixed)

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:m11][webdriver:relnote])

Attachments

(1 file)

To differentiate between WebDriver classic (HTTP) and WebDriver BiDi the classic spec got a HTTP flag added:
https://w3c.github.io/webdriver/#dfn-http-flag

This flag would be needed for Multiple Session support (bug 1862018).

Points: --- → 3
Priority: -- → P2
Whiteboard: [webdriver:backlog]

It looks like that I missed to update the whiteboard for this bug given that this bug is listed as required for M11 and after implementing bug 1884650 I would agree to have it in this milestone.

Assignee: nobody → hskupin
Blocks: 1824220
Status: NEW → ASSIGNED
Whiteboard: [webdriver:backlog] → [webdriver:m11]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f5bdb253c2e
[remote] Add support for "HTTP flag" in WebDriver Session. r=webdriver-reviewers,jdescottes

Backed out for causing mochitets failures in browser_Troubleshoot.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | toolkit/modules/tests/browser/browser_Troubleshoot.js | Schema mismatch, Error: Validation error: Object is not of the expected type: object=["[GFX1-]: glxtest: ManageChildProcess failed\n","[GFX1-]: No GPUs detected via PCI\n"], schema={"type":"object","properties":{"key":{"required":true,"type":"string"},"args":{"required":false,"type":"object"}}} -
Flags: needinfo?(hskupin)

This is a failure when getting the GfxInfo. A change that I've made is the following:

-        "moz:headless",
-        Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo).isHeadless,
[..]
+ ChromeUtils.defineLazyGetter(lazy, "isHeadless", () => {
+    return Cc["@mozilla.org/gfx/info;1"].createInstance(Ci.nsIGfxInfo).isHeadless;
+. });

So I've accidentally replaced the call to getService() with getInstance(), which clearly should fail. Still interesting that this is still working fine on other platforms than Linux and even Linux opt. I'll fix and push again.

Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/374f26d432ea
[remote] Add support for "HTTP flag" in WebDriver Session. r=webdriver-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Whiteboard: [webdriver:m11] → [webdriver:m11][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.