PromptListener "closed" event needs to include prompt type
Categories
(Remote Protocol :: Agent, enhancement, P2)
Tracking
(firefox129 fixed)
Tracking | Status | |
---|---|---|
firefox129 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [webdriver:m11])
Attachments
(2 files, 3 obsolete files)
For both of the opened
and closed
events the PromptListener does not include the type of prompt, which makes it impossible for the closed
event to determine which kind of prompt was open. As such we should add a promptType
field under details
to hand this information to the consumer of the event.
Assignee | ||
Comment 1•1 month ago
|
||
We actually don't need it for the open
event given that it can easily be retrieved from the prompt.promptType
property.
Assignee | ||
Updated•1 month ago
|
Assignee | ||
Comment 2•1 month ago
|
||
Assignee | ||
Comment 3•1 month ago
|
||
Assignee | ||
Comment 4•1 month ago
|
||
Depends on D213074
Updated•1 month ago
|
Assignee | ||
Comment 5•1 month ago
|
||
Assignee | ||
Comment 6•1 month ago
|
||
Updated•1 month ago
|
Updated•1 month ago
|
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/faedbd0638de [browser] Return promptType in DOMModalDialogClosed event details. r=Gijs,tabbrowser-reviewers,dao https://hg.mozilla.org/integration/autoland/rev/54d2d882de34 [remote] Return "promptType" in PromptListener "closed" events. r=webdriver-reviewers,Sasha
Updated•1 month ago
|
Comment 8•1 month ago
|
||
Comment on attachment 9406623 [details]
Bug 1901489 - [geckoview] Return promptType in details for DOMModalDialogClosed event.
Revision D213213 was moved to bug 1824220. Setting attachment 9406623 [details] to obsolete.
Comment 9•1 month ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/faedbd0638de
https://hg.mozilla.org/mozilla-central/rev/54d2d882de34
Description
•