Closed Bug 1876062 Opened 6 months ago Closed 1 month ago

Skip "beforeunload" prompts when closing tabs during browser.removeUserContext

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
2

Tracking

(firefox129 fixed)

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: jdescottes, Assigned: whimboo)

References

Details

(Whiteboard: [webdriver:m11], [wptsync upstream])

Attachments

(2 files)

Bug 1876062 - [webdriver-bidi] Skip "beforeunload" prompts when closing tabs in "browser.removeUserContext".
48 bytes, text/x-phabricator-request
Details | Review
Bug 1876062 - [wdspec] Add test for skipping "beforeunload" prompts for "browser.removeUserContext".
48 bytes, text/x-phabricator-request
Details | Review

Per spec, we should skip beforeunload prompts when closing container tabs. We should be able to expose the skipPermitUnload argument of tabbrowser removeTab via ContextualIdentityService.closeContainerTabs.

However to test this properly we need first to allow beforeunload prompts not to be skipped.

Blocks: 1870840
No longer blocks: 1870839
Depends on: 1693857
Points: --- → 2
Priority: -- → P3
Whiteboard: [webdriver:m10]
Depends on: 1877191

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(hskupin)

We have to wait for bug 1824220 which will add more capability handling to be able at all to work with this kind of user prompt.

Type: defect → task
Depends on: 1824220
Flags: needinfo?(hskupin)
Whiteboard: [webdriver:m10] → [webdriver:m11]
Priority: P3 → P2
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6598932efaa
[webdriver-bidi] Skip "beforeunload" prompts when closing tabs in "browser.removeUserContext". r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/e08c61b4cc4a
[wdspec] Add test for skipping "beforeunload" prompts for "browser.removeUserContext". r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46811 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m11] → [webdriver:m11], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/c6598932efaa
https://hg.mozilla.org/mozilla-central/rev/e08c61b4cc4a

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.