Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe fix xcode cloud builds on main #9673

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Maybe fix xcode cloud builds on main #9673

merged 1 commit into from
Jun 19, 2024

Conversation

lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Jun 18, 2024 •
edited
Loading

Description

This PR bumps the minimum OS version for QTGlean to 14. Xcode Cloud builds on main are failing today with the following error: Invalid Bundle. The bundle MozillaVPN.app/Frameworks/QtGleanBindings.framework does not support the minimum OS Version specified in the Info.plist. which was likely triggered by moving CMAKE_OSX_DEPLOYMENT_TARGET for ios to 14 (#9656).

Update: I created a "Lesley testing" workflow in AppStoreConnect to test this and the build (3914) succeeded.

Reference

VPN-6462

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed
@lesleyjanenorton lesleyjanenorton marked this pull request as ready for review June 18, 2024 22:41
@lesleyjanenorton lesleyjanenorton changed the title DRAFT: Maybe fix xcode cloud builds on main Jun 18, 2024
mcleinman
mcleinman approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@lesleyjanenorton lesleyjanenorton merged commit 84fcc79 into main Jun 19, 2024
112 checks passed
@lesleyjanenorton lesleyjanenorton deleted the maybe-fix-xcode-cloud-build branch June 19, 2024 17:14
lesleyjanenorton added a commit that referenced this pull request Jun 20, 2024
@lesleyjanenorton
Maybe fix xcode cloud builds on main (#9673)
2c70ef1
lesleyjanenorton added a commit that referenced this pull request Jun 21, 2024
@lesleyjanenorton
🍒 Update iOS deployment target on release (#9677)
40badcc 
* Maybe fix xcode cloud builds on main (#9673)

* VPN-6445: Bump iOS deployment target to 14 (#9656)

* Bump iOS deployment target to 14

* Update deprecated enum case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@lesleyjanenorton @mcleinman