Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-6445: Bump iOS deployment target to 14 #9656

Merged
merged 2 commits into from
Jun 17, 2024
Merged

VPN-6445: Bump iOS deployment target to 14 #9656

merged 2 commits into from
Jun 17, 2024

Conversation

lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Jun 11, 2024 •
edited
Loading

Description

This PR bumps the CMAKE_OSX_DEPLOYMENT_TARGET for ios to "14.0" and is the sibling of #9655. I opened these as separate pull requests expecting a lot of grief that has thankfully not yet materialized. Happy to consolidate.

Reference

VPN-6445

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed
@lesleyjanenorton lesleyjanenorton changed the title Bump iOS deployment target to 14 Jun 11, 2024
@lesleyjanenorton lesleyjanenorton changed the title Draft: Bump iOS deployment target to 14 Jun 12, 2024
@lesleyjanenorton lesleyjanenorton changed the title Bump iOS deployment target to 14 Jun 12, 2024
@lesleyjanenorton lesleyjanenorton marked this pull request as ready for review June 12, 2024 00:49
oskirby
oskirby reviewed Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@oskirby oskirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I approve in spirit, the IOS build job never actually ran so this didn't get tested in CI.

Also note that we need to look out for deprecated features, for example:
@lesleyjanenorton lesleyjanenorton force-pushed the bump-ios-deployment-target branch 2 times, most recently from f095ebb to 1366bf2 Compare June 14, 2024 18:25
oskirby
oskirby approved these changes Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@oskirby oskirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lesleyjanenorton lesleyjanenorton merged commit 83a2074 into main Jun 17, 2024
114 checks passed
@lesleyjanenorton lesleyjanenorton deleted the bump-ios-deployment-target branch June 17, 2024 14:48
@lesleyjanenorton lesleyjanenorton mentioned this pull request Jun 18, 2024
Merged
5 tasks
lesleyjanenorton added a commit that referenced this pull request Jun 20, 2024
@lesleyjanenorton
VPN-6445: Bump iOS deployment target to 14 (#9656)
0504033 
* Bump iOS deployment target to 14

* Update deprecated enum case
lesleyjanenorton added a commit that referenced this pull request Jun 21, 2024
@lesleyjanenorton
🍒 Update iOS deployment target on release (#9677)
40badcc 
* Maybe fix xcode cloud builds on main (#9673)

* VPN-6445: Bump iOS deployment target to 14 (#9656)

* Bump iOS deployment target to 14

* Update deprecated enum case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@lesleyjanenorton @oskirby