chore(*): Use new createContentDigest helper #8992

samscha · 2018-10-10T14:01:05Z

Note: this is my first pr to Gatsby so if I'm missing something (best practices included), please do tell me about them and I'll update this/future pr's.

Added createContentDigest helper for gatsby-transformer-remark and gatsby-source-filesystem.

I opened this pr right now mainly because I wanted to make sure I was adding the createContentDigest helper to these two plugins correctly and not breaking anything (before going on to other plugins).

If it's more convenient, and I have verification I correctly added the createContentDigest helper to these two plugins, this pr can be closed and I can open a new pr later with more plugins that have the createContentDigest helper added.

Thanks!

from
#8805

DSchau

This looks good! I've seen a few PRs now where createContentDigest is mocked in tests, which is technically fine but I think we'd prefer if the real implementation was made available to nodes so snapshots track any regressions there.

Sound like work you're interested in fixing up?

samscha · 2018-10-10T15:32:22Z

Yes I can definitely work on re-implementing tests to use createContentDigest.

For clarification, this would mean that the snapshots, instead of having contentDigest, would have their unique md5 hash?

Thanks!

DSchau · 2018-10-10T15:32:53Z

@samscha that is exactly right!

gatsby-source-hacker-news gatsby-source-lever gatsby-source-mongodb gatsby-transformer-excel

pieh · 2018-10-18T12:43:28Z

packages/gatsby-source-contentful/src/cache-image.js

 const { resolve, parse } = require(`path`)

 const axios = require(`axios`)
 const { pathExists, createWriteStream } = require(`fs-extra`)

+const createContentDigest = require(`../../gatsby/src/utils/create-content-digest`)


we should pass this from caller and not import directly here

we should only import it directly for tests

thank you for the comment! getting from the caller makes a lot more sense! I fixed all but two of these instances in previous commits.

I'm going to work on removing the import from gatsby-source-contentful and gatsby-transformer-sqip (both use the cache-image code mentioned above)

remove direct import

…s/createContentDigest-plugins

wardpeet

Looks good to me! I like const { createContentDigest } = require(gatsby/utils) we probably want to upgrade all code when we're done migrating

gatsbot · 2019-04-23T12:20:54Z

Holy buckets, @samscha — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

KyleAMathews · 2019-04-23T12:22:05Z

Thanks!

This reverts commit c91d110.

KyleAMathews · 2019-04-23T13:45:17Z

Hey @samscha! We unfortunately had to revert this — looks like there were a couple of problems that we didn't catch before merging. Could you put up a new PR with these fixes?

Basically we need to keep the old implementations around as a fallback as many people won't upgrade gatsby when upgrading/installing a package so the utils.js file wouldn't be there. Also, currently that file is blocked from being published so that'd need fixed here https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/package.json#L147-L152

For the fallbacks, perhaps move them to a separate file e.g. fallbacks.js and add a TODO at the top to remove them in gatsby v3?

samscha · 2019-04-24T02:07:19Z

Got it. Will open up a new PR!

Where exactly would the fallbacks.js live?

KyleAMathews · 2019-04-24T03:24:08Z

Thanks!

The fallback.js file would be in the src directory for each plugin. It would try to require the core code and if that fails, use the fallback code. This way when v3 comes, all we need to do is to remove the fallback.js file and replace any code importing code from it to just use the core code.

* add createContentDigest helper for gatsby-transformer-remark * add createContentDigest helper for gatsby-source-filesystem * Added createContentDigest in test * Added missing createContentDigest param * update createContentDigest helper tests for gatsby-transformer-remark * update createContentDigest helper tests for gatsby-source-filesystem * update createContentDigest helper tests for gatsby-transformer-csv * add createContentDigest helper for internal-plugins/internal-data-bridge * add createContentDigest helper for gatsby-source-hacker-news * add createContentDigest helper for gatsby-transformer-excel * add createContentDigest helper for gatsby-source-mongodb * add createContentDigest helper for gatsby-source-lever * add createContentDigest helper for internal-plugins/query-runner * Updated gatsby dep gatsby-source-hacker-news gatsby-source-lever gatsby-source-mongodb gatsby-transformer-excel * add createContentDigest helper for gatsby-source-contentful * add createContentDigest helper for gatsby-transformer-hjson * add createContentDigest helper for gatsby-transformer-sqip * add createContentDigest helper for gatsby-source-npm-package-search * add createContentDigest helper for gatsby-transformer-toml * update createContentDigest helper for gatsby-source-mongodb remove direct import * update createContentDigest helper for gatsby-source-lever could not find import for createGraphQLNode, added helper anyways * update createContentDigest helper for internal-plugins/query-runner modify src/bootstrap (imports writeRedirects) * update createContentDigest helper for gatsby-source-npm-package-search * update createContentDigest helper for gatsby-source-contentful* TODO add ccd (createContentDigest) in cache-image * update createContentDigest helper for gatsby-transformer-sqip* TODO add ccd (createContentDigest) in generate-sqip * update createContentDigest helper for gatsby-transformer-sqip removed ccd from tests * use caret version selector * no need to import it - it's passed to `sourceNodes` * merge again * update to pass tests * update hash to use createContentDigest * move createContentDigest to import * move createContentDigest to import for gatsby-source-contentful * remove createContentDigest import in gatsby-source-filesystem test * rereplace createContentDigest with crypto in gatsby-source-filesystem * revert createContentDigest to crypto for create-file-node in gatsby-source-filesystem * revert createContentDigest for gatsby-plugin-sharp * update crypto misspell * revert gatsby-remark-contentful and gatsby-source-contentful * fix old code * fix old code v2 * update gatsby pkg * revert gatsby-transformer-remark * add export for gatsby utils * update gatsby-source-filesystem * revert gatsby-source-graphql * revert gatsby-source-graphql * revert gatsby-source-hacker-news * revert gatsby-source-lever * revert gatsby-source-medium * revert gatsby-source-mongodb * revert gatsby-source-mongodb mapping * revert gatsby-source-npm-package-search * revert gatsby-source-wikipedia * revert gatsby-source-wordpress * revert gatsby-transformer-csv * revert gatsby-transformer-documentationjs * revert gatsby-transformer-excel * revert gatsby-transformer-hjson * revert other packages * revert some pkgs * add gatsby * move gatsby to peerdeps

…gatsbyjs#13568) This reverts commit c91d110.

samscha requested a review from a team October 10, 2018 14:07

DSchau approved these changes Oct 10, 2018

View reviewed changes

DSchau added the status: WIP label Oct 10, 2018

samscha mentioned this pull request Oct 12, 2018

[NO-MERGE] Enhancing createContentDigest tests -- requesting help #9072

Closed

samscha requested a review from a team as a code owner October 15, 2018 17:00

samscha requested a review from a team October 15, 2018 17:00

samscha requested a review from a team as a code owner October 15, 2018 17:00

samscha added 19 commits October 17, 2018 11:03

add createContentDigest helper for gatsby-transformer-remark

353b60d

add createContentDigest helper for gatsby-source-filesystem

9c0e187

Added createContentDigest in test

d3b3931

Added missing createContentDigest param

4c13027

update createContentDigest helper tests for gatsby-transformer-remark

3bfd43a

update createContentDigest helper tests for gatsby-source-filesystem

46e277a

update createContentDigest helper tests for gatsby-transformer-csv

d8e9689

add createContentDigest helper for internal-plugins/internal-data-bridge

096f1c8

add createContentDigest helper for gatsby-source-hacker-news

9d28bec

add createContentDigest helper for gatsby-transformer-excel

f379bb6

add createContentDigest helper for gatsby-source-mongodb

2320a48

add createContentDigest helper for gatsby-source-lever

0a1e9c2

add createContentDigest helper for internal-plugins/query-runner

a5e2cd4

Updated gatsby dep

917b140

gatsby-source-hacker-news gatsby-source-lever gatsby-source-mongodb gatsby-transformer-excel

add createContentDigest helper for gatsby-source-contentful

e936637

add createContentDigest helper for gatsby-transformer-hjson

524ca7b

add createContentDigest helper for gatsby-transformer-sqip

9db133e

add createContentDigest helper for gatsby-source-npm-package-search

90e40f7

add createContentDigest helper for gatsby-transformer-toml

66674f1

pieh reviewed Oct 18, 2018

View reviewed changes

update createContentDigest helper for gatsby-source-mongodb

002c8c3

remove direct import

samscha added 9 commits March 9, 2019 16:46

revert gatsby-source-wordpress

c105a3f

revert gatsby-transformer-csv

90b54c5

revert gatsby-transformer-documentationjs

cf92d0e

revert gatsby-transformer-excel

18c86b1

revert gatsby-transformer-hjson

da90859

revert other packages

e005647

revert some pkgs

2e5846c

add gatsby

66136a0

Merge branch 'master' of https://github.com/samscha/gatsby into topic…

5a313e4

…s/createContentDigest-plugins

frinyvonnick mentioned this pull request Apr 1, 2019

feat: update gatsby plugins to use new createContentDigest helper #8805

Closed

wardpeet self-assigned this Apr 23, 2019

wardpeet added 2 commits April 23, 2019 12:24

Merge remote-tracking branch 'upstream/master' into pr/8992

5e908e6

move gatsby to peerdeps

fd1217d

wardpeet changed the title ~~add createContentDigest helper for gatsby-transformer-remark and gatsby-source-filesystem~~ Apr 23, 2019

wardpeet removed their assignment Apr 23, 2019

wardpeet approved these changes Apr 23, 2019

View reviewed changes

wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Apr 23, 2019

KyleAMathews merged commit c91d110 into gatsbyjs:master Apr 23, 2019

KyleAMathews mentioned this pull request Apr 23, 2019

Error: Cannot find module 'gatsby/utils' #13567

Closed

KyleAMathews added a commit that referenced this pull request Apr 23, 2019

Revert "chore(*): Use new createContentDigest helper (#8992)"

c221299

This reverts commit c91d110.

KyleAMathews mentioned this pull request Apr 23, 2019

Revert "chore(*): Use new createContentDigest helper (#8992)" #13568

Merged

pieh pushed a commit that referenced this pull request Apr 23, 2019

Revert "chore(*): Use new createContentDigest helper (#8992)" (#13568)

fb45f7e

This reverts commit c91d110.

samscha mentioned this pull request Apr 24, 2019

fix: Add fallback for createContentDigest #13584

Merged

mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023

Revert "chore(*): Use new createContentDigest helper (gatsbyjs#8992)" (…

b800945

…gatsbyjs#13568) This reverts commit c91d110.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(*): Use new createContentDigest helper #8992

chore(*): Use new createContentDigest helper #8992

samscha commented Oct 10, 2018

DSchau left a comment

samscha commented Oct 10, 2018

DSchau commented Oct 10, 2018

pieh Oct 18, 2018

pieh Oct 18, 2018

samscha Oct 18, 2018

wardpeet left a comment

gatsbot bot commented Apr 23, 2019

KyleAMathews commented Apr 23, 2019

KyleAMathews commented Apr 23, 2019

samscha commented Apr 24, 2019 •

edited

Loading

KyleAMathews commented Apr 24, 2019

chore(*): Use new createContentDigest helper #8992

chore(*): Use new createContentDigest helper #8992

Conversation

samscha commented Oct 10, 2018

DSchau left a comment

Choose a reason for hiding this comment

samscha commented Oct 10, 2018

DSchau commented Oct 10, 2018

pieh Oct 18, 2018

Choose a reason for hiding this comment

pieh Oct 18, 2018

Choose a reason for hiding this comment

samscha Oct 18, 2018

Choose a reason for hiding this comment

wardpeet left a comment

Choose a reason for hiding this comment

gatsbot bot commented Apr 23, 2019

KyleAMathews commented Apr 23, 2019

KyleAMathews commented Apr 23, 2019

samscha commented Apr 24, 2019 • edited Loading

KyleAMathews commented Apr 24, 2019

samscha commented Apr 24, 2019 •

edited

Loading