Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(*): Use new createContentDigest helper (#8992)" #13568

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Apr 23, 2019

This reverts commit c91d110 and PR #8992

We can't introduce a new file to the core gatsby package and then also update packages to use it without having a fallback as people often update/install packages without updating core.

@KyleAMathews KyleAMathews requested a review from a team as a code owner April 23, 2019 13:32
@pieh pieh merged commit fb45f7e into master Apr 23, 2019
@KyleAMathews KyleAMathews deleted the quick-fix branch April 23, 2019 13:35
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do do this--we need to ensure we update the peerDependency on gatsby.

Also isn't the path gatsby/dist/utils? I think that's more of the issue here--no version of Gatsby would have these afaik.

https://unpkg.com/gatsby@2.3.26/

@KyleAMathews
Copy link
Contributor Author

There was a new file added https://github.com/gatsbyjs/gatsby/pull/8992/files#diff-7b0d4dc1ad15094456fc37848d323bb1

The problem is that npm doesn't enforce peerDependencies so while there'd be a warning, most people wouldn't see that and not understand why upgrading/installing a package broke things.

@KyleAMathews
Copy link
Contributor Author

Another problem @pieh just pointed out is that the utils.js file wasn't published due to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/package.json#L147-L152

@Olanetsoft
Copy link
Contributor

I still get the same error how do I fix it, please?

mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants