Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose totals for memory in heap snapshot. #5593

Merged
merged 24 commits into from
Apr 3, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
-
  • Loading branch information
polina-c committed Apr 3, 2023
commit 7ed0117a904d38998b05401c84fa0ba09d3db8d8
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ class _SnapshotSizeView extends StatelessWidget {
.map<String>(
(e) => '${e.key}: ${prettyPrintBytes(e.value, includeUnit: true)}',
)
// TODO(polina-c): consider using vertical divider instead of text.
.join(' | '),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but consider using a vertical divider instead of text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added TODO

overflow: TextOverflow.ellipsis,
textAlign: TextAlign.right,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class MemoryFootprint {
required this.reachable,
});

/// Reachable and unreachable dart size.
/// Reachable and unreachable total dart heap size.
final int dart;
polina-c marked this conversation as resolved.
Show resolved Hide resolved

/// Subset of [dart].
Expand Down