Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose totals for memory in heap snapshot. #5593

Merged
merged 24 commits into from
Apr 3, 2023
Merged

Expose totals for memory in heap snapshot. #5593

merged 24 commits into from
Apr 3, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Mar 31, 2023 •
edited
Loading

Screenshot 2023-04-01 at 3 55 54 PM
@polina-c polina-c requested a review from bkonyi as a code owner March 31, 2023 22:55
@polina-c polina-c requested a review from a team as a code owner March 31, 2023 22:56
bkonyi
bkonyi approved these changes Apr 3, 2023
View reviewed changes
packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/snapshot_control_pane.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/snapshot_control_pane.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/snapshot_control_pane.dart
.map<String>(
(e) => '${e.key}: ${prettyPrintBytes(e.value, includeUnit: true)}',
)
.join(' | '),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but consider using a vertical divider instead of text.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added TODO
packages/devtools_app/lib/src/shared/memory/simple_items.dart Show resolved Hide resolved
@polina-c polina-c merged commit 2015abf into flutter:master Apr 3, 2023
@polina-c polina-c deleted the memory_ branch April 3, 2023 18:12
@polina-c polina-c mentioned this pull request Apr 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@polina-c @bkonyi