Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network copy bug #5476

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Fix network copy bug #5476

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4944e07
make sure that widget is updated when data is updated
CoderDake Mar 21, 2023
1986fed
Make the request atab copy buttons behave better with the updating data.
CoderDake Mar 22, 2023
c431b3f
release notes
CoderDake Mar 22, 2023
bd1895a
bennits
Mar 22, 2023
106d0cf
whitespace fix
CoderDake Mar 24, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bennits
  • Loading branch information
Daniel Chevalier committed Mar 22, 2023
commit bd1895a92a826562818ec12e0630682c2cee6f11
4 changes: 3 additions & 1 deletion packages/devtools_app/lib/src/screens/network/network_request_inspector_views.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,15 +178,17 @@ class HttpViewTrailingCopyButton extends StatelessWidget {
const HttpViewTrailingCopyButton(this.data, this.dataSelector);
final DartIOHttpRequestData data;
final String? Function(DartIOHttpRequestData) dataSelector;

@override
CoderDake marked this conversation as resolved.
Show resolved Hide resolved
Widget build(BuildContext context) {
return ValueListenableBuilder(
valueListenable: data.requestUpdatedNotifier,
builder: (context, __, ___) {
final dataToCopy = dataSelector(data);
final isLoading = data.isFetchingFullData;
if (dataToCopy == null || dataToCopy == '' || isLoading)
if (dataToCopy == null || dataToCopy.isEmpty || isLoading){
return Container();
CoderDake marked this conversation as resolved.
Show resolved Hide resolved
}

return Align(
alignment: Alignment.centerRight,
Expand Down