Fix network copy bug #5476
Merged
Fix network copy bug #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderDake
requested review from
kenzieschmoll,
bkonyi and
a team
as code owners
bkonyi
approved these changes
Mar 22, 2023
packages/devtools_app/lib/src/screens/network/network_request_inspector_views.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/network/network_request_inspector_views.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/network/network_request_inspector_views.dart
Outdated
Show resolved
Hide resolved
| @@ -170,6 +170,37 @@ class HttpRequestView extends StatelessWidget { | |||
| } | |||
| } | |||
|
|
|||
| /// A button for copying [DartIOHttpRequestData] contents. | |||
| /// | |||
| /// If there is no content to copy, the button will not show. The copy contents | |||
There was a problem hiding this comment.
instead of hiding the button, we should just disable the onPressed handler. This will keep the UI consistent and not confuse users why sometimes the button is there and sometimes it is not. This is pretty standard across the rest of DevTools. For example, we don't remove a pause button when we are already paused, we just disable the onPressed handler so it shows up as disabled.
There was a problem hiding this comment.
SGTM
Issue created: #5519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5192
I noticed while testing the network response and requests tabs that one could click copy while the data was still loading.
this could result in empty copies.
Another issue I seemed to intermittently see was that the data would still be empty even after data was loaded. This only happened intermittently thought.
This PR changes the copy buttons so that they won't show until there is data for them to copy, and also makes sure that they are more tightly coupled with the state of data being fetched.