Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes getCldVideoUrl Safari Bug #468

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fixes getCldVideoUrl Safari Bug #468

merged 1 commit into from
Apr 17, 2024

Conversation

colbyfayock
Copy link
Collaborator

Description

getCldVideoUrl was simply using f_auto for automatic format selection, but f_auto can default to an image

https://cloudinary.com/documentation/video_optimization#specifying_media_type_with_f_auto

This is what was happening in Safari, but by providing the hint of f_auto:video we can be sure it will return a video format.

Issue Ticket Number

Fixes #467

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation
@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Apr 17, 2024 0:21am
@colbyfayock colbyfayock merged commit 2d3d953 into main Apr 17, 2024
7 checks passed
@colbyfayock colbyfayock deleted the bug/467-getcldvideourl-safari branch April 17, 2024 12:27
github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
@semantic-release-bot
chore(release): 6.5.1 [skip ci]
a41c736 
## [6.5.1](v6.5.0...v6.5.1) (2024-04-17)

### Bug Fixes

* Fixes getCldVideoUrl Safari Bug ([#468](#468)) ([2d3d953](2d3d953)), closes [#467](#467)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀
@colbyfayock colbyfayock restored the bug/467-getcldvideourl-safari branch May 6, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released
1 participant
@colbyfayock