Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getCldVideoUrl don't seem to work on safari #467

Closed
admin-next-horizon opened this issue Apr 16, 2024 · 2 comments · Fixed by #468
Closed

getCldVideoUrl don't seem to work on safari #467

admin-next-horizon opened this issue Apr 16, 2024 · 2 comments · Fixed by #468
Labels
released

Comments

@admin-next-horizon
Copy link

admin-next-horizon commented Apr 16, 2024 •
edited
Loading

It appears that getCldVideoUrl is not compatible with Safari. The video fails to play, like the player doesn't recognize the format. The example page also does not function properly : https://next.cloudinary.dev/getcldvideourl/examples
@colbyfayock colbyfayock mentioned this issue Apr 17, 2024
Merged
12 tasks
@colbyfayock
Copy link
Collaborator

thanks @admin-next-horizon - the URLs generated were simply using f_auto which can sometimes default to an image format: https://cloudinary.com/documentation/video_optimization#specifying_media_type_with_f_auto

specifying f_auto:video resolves this. a fix is going out shortly for it
colbyfayock added a commit that referenced this issue Apr 17, 2024
@colbyfayock
fix: Fixes getCldVideoUrl Safari Bug (#468)
2d3d953 
# Description

getCldVideoUrl was simply using `f_auto` for automatic format selection,
but `f_auto` can default to an image


https://cloudinary.com/documentation/video_optimization#specifying_media_type_with_f_auto

This is what was happening in Safari, but by providing the hint of
`f_auto:video` we can be sure it will return a video format.

## Issue Ticket Number

Fixes #467 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/cloudinary-community/next-cloudinary/issues/<ISSUE_NUMBER>
-->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/cloudinary-community/next-cloudinary/issues)
ticket for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/cloudinary-community/next-cloudinary/pulls)
for the same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue Apr 17, 2024
@semantic-release-bot
chore(release): 6.5.1 [skip ci]
a41c736 
## [6.5.1](v6.5.0...v6.5.1) (2024-04-17)

### Bug Fixes

* Fixes getCldVideoUrl Safari Bug ([#468](#468)) ([2d3d953](2d3d953)), closes [#467](#467)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released
2 participants
@colbyfayock @admin-next-horizon