formulae: set root_url to GitHub Releases url #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Bo98
reviewed
Aug 22, 2020
|
Not entirely sure on the |
dawidd6
force-pushed
the
github-releases
branch
2 times, most recently
from
ec83dcd
to
7cb8a23
Compare
MikeMcQuaid
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Makes sense to me (minus @Bo98's question I'd like to see figured out). --ci-upload should probably be configured to fail with a helpful message given this case, too?
|
Yes, Also added a check for |
dawidd6
force-pushed
the
github-releases
branch
from
c31ecec
to
2af514b
Compare
MikeMcQuaid
reviewed
Aug 24, 2020
dawidd6
force-pushed
the
github-releases
branch
from
2af514b
to
3f4c10b
Compare
MikeMcQuaid
approved these changes
Aug 24, 2020
dawidd6
force-pushed
the
github-releases
branch
from
3f4c10b
to
0d4f2a4
Compare
dawidd6
force-pushed
the
github-releases
branch
from
0d4f2a4
to
4a2debf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not testing core tap (and a bunch of other conditions), set the root_url to GitHub releases url.
This url would later be used in
brew pr-uploadto determine what release to create.