Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bottle uploads to GitHub Releases #8410

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Support bottle uploads to GitHub Releases #8410

merged 1 commit into from
Sep 15, 2020

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Aug 20, 2020

In this PR I'll try to add support for an alternative to Bintray, that is GitHub Releases.
It will be mostly useful for third-party taps, they won't have to create Bintray accounts and stuff.

Idea from @MikeMcQuaid

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
@dawidd6 dawidd6 marked this pull request as draft August 20, 2020 12:53
MikeMcQuaid
MikeMcQuaid reviewed Aug 20, 2020
View reviewed changes
Library/Homebrew/dev-cmd/bottle.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/github.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/github.rb Outdated Show resolved Hide resolved
@dawidd6 dawidd6 force-pushed the github-releases branch 2 times, most recently from 4859367 to a28e59c Compare August 20, 2020 18:56
@dawidd6
Copy link
Member Author

dawidd6 commented Aug 22, 2020

Homebrew/homebrew-test-bot#486
@dawidd6
Copy link
Member Author

dawidd6 commented Aug 22, 2020

With this PR and those test-bot additions, it works like that for now:
https://github.com/dawidd6/homebrew-test/releases/tag/test-formula-git-revision-0.3.2

brew fetch test-formula-git-revision pulls the bottle from GitHub just fine.
@dawidd6 dawidd6 force-pushed the github-releases branch 2 times, most recently from cb8f3d8 to c7a252c Compare August 22, 2020 16:47
MikeMcQuaid
MikeMcQuaid reviewed Aug 24, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looking good so far but questions on how/why it works how it does. Nice work!
Library/Homebrew/dev-cmd/pr-upload.rb Outdated Show resolved Hide resolved
@dawidd6 dawidd6 changed the title WIP: support bottle uploads to GitHub Releases Aug 24, 2020
@dawidd6 dawidd6 marked this pull request as ready for review August 26, 2020 17:44
MikeMcQuaid
MikeMcQuaid reviewed Sep 9, 2020
View reviewed changes
Library/Homebrew/dev-cmd/pr-upload.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/pr-upload.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/github.rb Outdated Show resolved Hide resolved
@dawidd6 dawidd6 force-pushed the github-releases branch 4 times, most recently from c59290e to a8fd284 Compare September 12, 2020 11:00
@dawidd6 @MikeMcQuaid
Support bottle uploads to GitHub Releases
f6601ce 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@dawidd6 dawidd6 merged commit 14741e3 into Homebrew:master Sep 15, 2020
@dawidd6 dawidd6 deleted the github-releases branch September 15, 2020 09:59
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
3 participants
@dawidd6 @MikeMcQuaid @BrewTestBot