SlideShare a Scribd company logo
Code Review Checklist

Have You Checked For ?
 Dead/Redundant code
 Duplication
 Complexity

(cyclomatic, large functions, block
depth)
 Dependencies ( added/changed )
 Assumptions and Side effects
 Is it Tell or Ask ?
 Is it easy to Misuse ?
 Is it Global State ?
 Names and Magic Numbers
January 14

Commercial in confidence. © Nitin Bhide

More Related Content

Code Review Checklist

  • 1. Code Review Checklist Have You Checked For ?  Dead/Redundant code  Duplication  Complexity (cyclomatic, large functions, block depth)  Dependencies ( added/changed )  Assumptions and Side effects  Is it Tell or Ask ?  Is it easy to Misuse ?  Is it Global State ?  Names and Magic Numbers January 14 Commercial in confidence. © Nitin Bhide