using string.format properly to display a string in winform c#

Question

i have a window form in which display all directories in listview .for copying files if a file already exist its copies it again appending file.txt(1) with it.and if this is again copied file.txt(2)

string fileNameOnly = Path.GetFileNameWithoutExtension(file);
string extension = Path.GetExtension(file);
string pathDir = Path.GetDirectoryName(file);
string tempFileName = string.Format("{0}({1})", fileNameOnly, count++);
string newfileName = Path.Combine(pathDir, tempFileName + extension);

if (MessageBox.Show(file + "is already exists\r\nDo you want to copy Again?",
                    "Overwrite", MessageBoxButtons.OKCancel,
                    MessageBoxIcon.Asterisk) == DialogResult.OK)
{
    //  Directory.Move(file, Path.Combine(new string[] { DestinationFolder, newfileName }));
    File.Copy(file, Path.Combine(new string[] { DestinationFolder, newfileName }));
    MessageBox.Show("File Copied");

but the problem is this that when i copy the files again and again the pattern is like file.txt(1)/file.txt(1)(1)/file.txt(1)(1)(1)/ it doesnt increment the number inside ..i dont know how to increment the count every time i copy..can anybody tell what im doing wrong

Answer 1

count++ means that the variable gets incremented after it's evaluated. You probably want this instead:

string tempFileName = string.Format("{0}({1})", fileNameOnly, ++count);

(note that i've also moved the paranthesis outside of the braces)

Edit:

Also, you're always using the complete file-name(without extension) to create the new one. But you should replace the old-number with old-number+1.

Try this instead:

int count = 0;
string fullPath = file;
while (File.Exists(fullPath))
{
    string fileName = Path.GetFileName(file);
    string extension = Path.GetExtension(fileName);
    string fileNameWithoutExtension = Path.GetFileNameWithoutExtension(fileName);
    int lastIndexOfOpenBracket = fileNameWithoutExtension.LastIndexOf('(');
    string fileNameWithoutNumber = fileNameWithoutExtension.Substring(0, lastIndexOfOpenBracket);
    fileNameWithoutExtension = string.Format("{0}({1})", fileNameWithoutNumber, ++count);
    fullPath = Path.Combine(DestinationFolder, fileNameWithoutExtension + extension);
}
if (MessageBox.Show(file + " already exists\r\nDo you want to copy Again?",
        "Overwrite", MessageBoxButtons.OKCancel,
        MessageBoxIcon.Asterisk) == DialogResult.OK)
{
    File.Copy(file, fullPath);
    MessageBox.Show("File Copied");
}

Answer 2

I think following should work for you.

string tempFileName = string.Format("{0}({1})", fileNameOnly, count++);

Anything inside {} is a placeholder. you have used {(1)} which will always be 1.

Answer 3

you have done simple mistake

string tempFileName = string.Format("{0}({1})", fileNameOnly, count++);

replace {(1)} with ({1})