Jetbrains PHPStorm 5.0.4 tells me I have a Duplicated jQuery Selector

Question

This is the piece of jQuery I wrote,

$('#editUser').click(function() {
    if ($(".selectedTR")[0]) {
        if($('.form-actions').is(':visible')) {
            $('.form-actions').slideUp('slow',function() {
                $('.form-actions > h3').text("Edit");
            }).css('display', 'none');
        }

        $('.form-actions').css('display', 'block').slideDown('slow');
    } else {
        alert("Please select a user");
    }
});

How can I remove the duplicated selectors?

Answer 1

You can cache the selector by putting it in a variable. Try this:

$('#editUser').click(function() {
    if ($(".selectedTR").length) { 
        var $formActions = $('.form-actions');
        if ($formActions.is(':visible')) {
            $formActions.slideUp('slow', function() {
                $formActions.children('h3').text("Edit");
            }).css('display', 'none');
        }
        $formActions.css('display', 'block').slideDown('slow');
    } else {
        alert("Please select a user");
    }
});