Create Task
Maniphest T147585

Format menu doesn't detect headings without spaces in NWE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

@NicoV reports that ==Test== was not detected as a section heading. (Perhaps it relies upon the presence of spaces, i.e., == Test == ?)

Details

SubjectRepoBranchLines +/-
Fix detection of headings in NWE format menumediawiki/extensions/VisualEditormaster+3 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Whatamidoing-WMF created this task.Oct 6 2016, 6:29 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 6 2016, 6:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Esanders subscribed.Oct 6 2016, 6:33 PM

I need more details here. Why are we talking about wikitext in VE?

• Whatamidoing-WMF added a comment.Oct 6 2016, 8:55 PM

Because NicoV was testing the wikitext mode on the Beta Cluster yesterday.

NicoV added a comment.Oct 7 2016, 9:02 AM

@Esanders I was testing the new wikitext editor (included in VE) on beta, and when editing the World page, headings like == World literature == where correctly detected as a Heading, but not ==Test== (which has no whitespace characters between the heading markers and the heading itself).

• Esanders renamed this task from ==Heading== not detected to Format menu doesn't detect headings without spaces in NWE.Oct 7 2016, 4:44 PM
gerritbot subscribed.Oct 7 2016, 4:45 PM

Change 314723 had a related patch set uploaded (by Esanders):
Fix detection of headings in NWE format menu

https://gerrit.wikimedia.org/r/314723

gerritbot added a project: Patch-For-Review.Oct 7 2016, 4:45 PM
Jdforrester-WMF assigned this task to • Esanders.Oct 7 2016, 4:47 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki-2017WikitextEditor.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
gerritbot added a comment.Oct 10 2016, 10:46 PM

Change 314723 merged by jenkins-bot:
Fix detection of headings in NWE format menu

https://gerrit.wikimedia.org/r/314723

• AlexMonk-WMF closed this task as Resolved.Oct 10 2016, 10:58 PM
• AlexMonk-WMF removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 10 2016, 11:00 PM
Jdforrester-WMF added a parent task: T141149: Provide a Beta Feature of a modern wikitext editor integrated into the visual editor.Oct 12 2016, 4:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits