Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the focus stays in the editor after execAction for Firefox. #1496 #1497

Merged
merged 1 commit into from
Jun 2, 2019

Conversation

peterchappell
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? no
Fixed tickets #1496
License MIT

Description

For some reason in Firefox, the body is the focussed element after exec action. If there's a nicer way to do this (or to stop the body being the focus) let me know and I'll be happy to investigate further.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 94.037% when pulling 24edffa on peterchappell:fix-focus-selection-issue-firefox into 9156a11 on yabwe:master.

@rdeprey rdeprey merged commit 83e1872 into yabwe:master Jun 2, 2019
@reneklacan
Copy link

@peterchappell

Hello, thank you for this change, is there any downside of calling .focus() all the time, not just for FF?

Because it seems to be fixing some buggy behaviour I'm seeing on Chrome, specifically when you click on toolbar (with static: true, updateOnEmptySelection: true) button without any text selected.

Without .focus() editing area loses focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants