Ensure paragraph is selected for firefox. #1455 #1495
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure that we select the parent is selected if ever a br tag is the selected element when typing.
Description
I noticed in the
handleKeyupmethod that sometimes the selected node was a BR tag. When this is the case, typing does nothing. The use case in the issue (which was a problem for me also) is when you press enter from a new heading - so I've added a fix for that scenario (wrapped in the isFF util). I also added a fallback check - since I've seen other random places where typing seems to get "trapped".Very happy to work with you if you have suggestions for improvement - as I'm not fully immersed in the library (or in contentEditable in general).
--
Please, don't submit
/distfiles with your PR!