Cleanup after ordered/unordered list item removal #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
approved these changes
Apr 17, 2018
|
Still failing :( https://travis-ci.org/yabwe/medium-editor/builds/367515342#L2759 |
|
@j0k3r Ah, my bad. Honestly, my fault for not having IE available to test. But it's interesting how IE actually does what Chrome, Safari and FF needs a fix for. Sprry for that. Should I be making a new PR or is there a way to revert this one? |
|
Go on and create a new PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed my test cases for Edge, and fixed the cleanup in Firefox when selection start lays outside a text node.
All Saucelabs tests should pass now.