Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes imagesrcset and imagesizes attributes on <link> #4048

Merged
merged 14 commits into from
Feb 25, 2019

Conversation

domfarolino
Copy link
Member

@domfarolino domfarolino commented Sep 26, 2018

HTML Standard-size changes for w3c/preload#120

TODO:

  • Consider an obtain the preload resource override for obtain the resource under the Link type "preload" section, that:
    • Checks to see if as == image, and if so
    • Do some stuff similar to step 9 and below in update the image data (like calling the image selection algorithm etc)
    • Otherwise defer to general obtain the resource algorithm
  • List imagesrcset and imagesizes mutations under appropriate times (PR is up)

Would appreciate some thoughts thus far; is this even the direction we want to go, i.e., making some of the algorithms in the images section fit the link element? /cc @zcorpan


/images.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/links.html ( diff )
/semantics.html ( diff )

@domfarolino domfarolino added needs tests Moving the issue forward requires someone to write tests impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation needs implementer interest Moving the issue forward requires implementers to express interest labels Sep 26, 2018
@zcorpan
Copy link
Member

zcorpan commented Sep 26, 2018

How do we handle the picture case?

@domfarolino
Copy link
Member Author

By picture case do you mean a link nested within a picture? If so, it seems <link> is not allowed to be nested in a <picture>, so I assume we just don't search for it as a parent, or its <source> children, in update the source set. If not, could you elaborate?

@eeeps
Copy link
Contributor

eeeps commented Sep 26, 2018

Other way around; imgsrcset and imgsizes would allow authors to preload resources that will be encountered by browsers in <img srcset>, later; it would be nice to allow authors to preload resources that will be encountered in <picture>/<source>, too.

E.g., how can authors preload a resource for:

<picture>
<source media=“(min-width: 800px)” srcset=“big.jpg 1200w, small.jpg 600w”>
<img srcset=“cropped-big.jpg 800w, cropped-small.jpg 400w”>
</picture>
@tabatkins
Copy link
Contributor

Presumably we can just use the pre-existing <link media>?

@eeeps
Copy link
Contributor

eeeps commented Sep 26, 2018

Oh, of course.

And link type can cover source type cases too, I bet 🎉

@zcorpan
Copy link
Member

zcorpan commented Sep 26, 2018

So if you have

<link rel=preload as=image media="(min-width: 800px)" imagesrcset="big.jpg 1200w, small.jpg 600w">
<link rel=preload as=image imagesrcset="cropped-big.jpg 800w, cropped-small.jpg 400w">

How can you tell if this is one "picture" or two "picture"s?

@domfarolino
Copy link
Member Author

Hmm, well I think it should not matter IIUC. The HTML in your example has potential of fetching two images, and I think any number of <img> or <picture> elements could fetch images that match the ones fetched + cached by the preloads? Or am I not understanding this correctly..

@eeeps
Copy link
Contributor

eeeps commented Sep 26, 2018

The HTML in the example [edit: to clear up confusion – in the picture example!] will only load one image. The srcset from the first matching <source> is used; after a match, subsequent <source>s and the <img srcset> are discarded.

But, you could relatively-easily make your <link media>s mutually exclusive:

<link rel=preload as=image media="(min-width: 800px)" imagesrcset="big.jpg 1200w, small.jpg 600w">
<link rel=preload as=image media="(max-width: 799px)" imagesrcset="cropped-big.jpg 800w, cropped-small.jpg 400w">

But! I don't know how you could do the same thing for type...?

@domfarolino
Copy link
Member Author

Gotcha. Yes it is a problem that the HTML @zcorpan provided will preload two images (assuming link media matches), even though the <picture> that both are intended for will only request one. So yeah, the link not having context of eventually-associated <picture>s can lead to a lot of unused preloads, which is quite bad for perf. Might be good to get some ideas on how to maybe make the association, so we don't have to tell devs to make their medias mutually exclusive in these contexts or something, just for the sake of being able to preload. (It'd be nice if the barrier for entry to preload responsive images were pretty low). Paging @irori for some ideas maybe, as he's recently worked on Chrome's impl.

@zcorpan
Copy link
Member

zcorpan commented Sep 27, 2018

How about adding a new as value? The processing of as=image would then look at previous siblings with as=source until a sibling is found that is not a link with as=source.

<link rel=preload as=source media="(min-width: 800px)" imagesrcset="big.jpg 1200w, small.jpg 600w">
<link rel=preload as=image imagesrcset="cropped-big.jpg 800w, cropped-small.jpg 400w">
@domfarolino
Copy link
Member Author

Ok, so:

<link rel=preload as=source media="(min-width: 800px)" imagesrcset="a...">
<link rel=preload as=image imagesrcset="cropped-a...">
<link rel=preload as=source media="(min-width: 800px)" imagesrcset="b...">
<link rel=preload as=image imagesrcset="cropped-b...">
<link rel=preload as=source media="(min-width: 800px)" imagesrcset="c...">
<link rel=preload as=image imagesrcset="cropped-c...">

...would preload three images, because processing <link rel=preload as=source> would not load anything, and would only be considered upon processing the next <link rel=preload as=image>, as an upstream sibling.

I also imagine we should say that when rel=preload && as=source:

  • href attribute must not be present, similar to what we do here for the source element
  • imagesrcset attribute must be present, similar to what we do here for the source element.

Given this, it seems we'll need a new update the source set algorithm that also takes in <link rel=preload as=image>s, in addition to the new <link rel=preload as=image> "obtain the preload resource" algorithm override.

If this is a decent enough proposal, I guess we can start trying to gather other implementer interest.

@domenic
Copy link
Member

domenic commented Sep 27, 2018

I'm stuck in meetings and can't read the above in detail, but I did just want to point out that as values are supposed to map mostly-1:1 with request destinations. It may be better to use a new rel, instead of a new as. Especially if we're changing the semantics to not be always-a-fetch as preload currently is.

I might be totally off-base due to not having read the above comments enough, and if so I apologize, but I wanted to throw this out there before people went too far.

@zcorpan
Copy link
Member

zcorpan commented Sep 27, 2018

I think that makes sense @domenic.

@domfarolino
Copy link
Member Author

Ah, that's a very good point, yeah as=source kinda breaks that destination mapping. A new rel is not a bad idea.

@zcorpan
Copy link
Member

zcorpan commented Sep 28, 2018

How about naming it preload-source?

<link rel=preload-source media="(min-width: 800px)" imagesrcset="a...">
<link rel=preload as=image imagesrcset="cropped-a...">
<link rel=preload-source media="(min-width: 800px)" imagesrcset="b...">
<link rel=preload as=image imagesrcset="cropped-b...">
<link rel=preload-source media="(min-width: 800px)" imagesrcset="c...">
<link rel=preload as=image imagesrcset="cropped-c...">
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@irori
Copy link

irori commented Oct 4, 2018

The implicit grouping of <link>s (0 or more <link rel=preload-source>s followed by a <link rel=preload as=image> forms a group) feels a little strange to me, but I can't think of a better alternative.

Perhaps we should file a new issue about the <picture> use case in w3c/preload and discuss there, while we focus on "preload for standalone <img srcset>" use-case here?

@yoavweiss
Copy link
Contributor

I don't think we should be grouping link elements together to try and mimic <picture>. IIUC, the same functionality can be achieved by using the media attributes, and "translating" picture's "first match wins" MQs into a set of mutually-exclusive MQs.

e.g. for

<picture>
    <source media="(max-width: 800px)" srcset="800px">
    <source media="(max-width: 1600px srcset="1600px">
    <img src="larger_than_1600">
</picture>

We'll use:

<link rel=preload as=image media="(max-width: 800px)" href="800px">
<link rel=preload as=image media="(min-width: 801px) and (max-width: 1600px)" href="1600px">
<link rel=preload as=image media="(min-width: 1601px)" href="larger_than_1600">

Does that make sense? Or am I overlooking something here?

@zcorpan
Copy link
Member

zcorpan commented Oct 15, 2018

That makes things more difficult for authors, it's not always easy or possible to make the MQ mutually exclusive. Also type is not mutually exclusive.

@yoavweiss
Copy link
Contributor

Fair enough. type and "exotic" MQs do indeed make things more complex...

@chrisdavidmills
Copy link

Docs need recorded on MDN content roadmap — https://trello.com/c/6YAMGL3B/132-html-link-element

@domfarolino
Copy link
Member Author

A bit less of a WIP now, but still have to work out the processing model for actually selecting and requesting the image.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 24, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127


--HG--
rename : testing/web-platform/tests/preload/dynamic-adding-preload-imagesrcset.tentative.html => testing/web-platform/tests/preload/dynamic-adding-preload-imagesrcset.html
rename : testing/web-platform/tests/preload/link-header-preload-srcset.tentative.html.headers => testing/web-platform/tests/preload/link-header-preload-imagesrcset.html.headers
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 25, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 25, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127
@sideshowbarker
Copy link
Contributor

heads-up @whatwg/documentation

marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#645156}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…o imagesrcset/imagesizes, a=testonly

Automatic update from web-platform-tests
Rename srcset/imgsizes link attributes to imagesrcset/imagesizes

This patch renames "srcset" and "imgsizes" attributes on link
to "imagesrcset" and "imagesizes" respectively, to match the latest
spec PR [1].

Note: this feature is behind experimental-web-platform-features flag.

[1] whatwg/html#4048

Bug: 813452
Change-Id: I8eabfbd734e2f29e36b7f7a3c4a32f1237b042b1
Reviewed-on: https://chromium-review.googlesource.com/c/1350414
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610782}

--

wpt-commits: a990dff8729c18279154f66650e83f01911216a4
wpt-pr: 14229

UltraBlame original commit: 3cee5ee7e89d121d039d5ddcca2bdf6a13010f8a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…butes to HTMLLinkElement, a=testonly

Automatic update from web-platform-tests
Add imageSrcset and imageSizes IDL attributes to HTMLLinkElement

This feature is behind the Experimental Web Platform feature flag.

Spec PR: whatwg/html#4048

Bug: 813452
Change-Id: I84c58035789b64a311637cebc4672d16661980c2
Reviewed-on: https://chromium-review.googlesource.com/c/1350558
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610990}

--

wpt-commits: dba9026fee0e7f5294181008a91b18c29030a397
wpt-pr: 14231

UltraBlame original commit: 050bf471d5cb823126cee83f31f3f78797e00867
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…o imagesrcset/imagesizes, a=testonly

Automatic update from web-platform-tests
Rename srcset/imgsizes link attributes to imagesrcset/imagesizes

This patch renames "srcset" and "imgsizes" attributes on link
to "imagesrcset" and "imagesizes" respectively, to match the latest
spec PR [1].

Note: this feature is behind experimental-web-platform-features flag.

[1] whatwg/html#4048

Bug: 813452
Change-Id: I8eabfbd734e2f29e36b7f7a3c4a32f1237b042b1
Reviewed-on: https://chromium-review.googlesource.com/c/1350414
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610782}

--

wpt-commits: a990dff8729c18279154f66650e83f01911216a4
wpt-pr: 14229

UltraBlame original commit: bb0ff9da601041924d15d595d43fcda992e9b17c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…butes to HTMLLinkElement, a=testonly

Automatic update from web-platform-tests
Add imageSrcset and imageSizes IDL attributes to HTMLLinkElement

This feature is behind the Experimental Web Platform feature flag.

Spec PR: whatwg/html#4048

Bug: 813452
Change-Id: I84c58035789b64a311637cebc4672d16661980c2
Reviewed-on: https://chromium-review.googlesource.com/c/1350558
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610990}

--

wpt-commits: dba9026fee0e7f5294181008a91b18c29030a397
wpt-pr: 14231

UltraBlame original commit: 988fb1f286accc0c15d9fc19410ed514598dfaf7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…o imagesrcset/imagesizes, a=testonly

Automatic update from web-platform-tests
Rename srcset/imgsizes link attributes to imagesrcset/imagesizes

This patch renames "srcset" and "imgsizes" attributes on link
to "imagesrcset" and "imagesizes" respectively, to match the latest
spec PR [1].

Note: this feature is behind experimental-web-platform-features flag.

[1] whatwg/html#4048

Bug: 813452
Change-Id: I8eabfbd734e2f29e36b7f7a3c4a32f1237b042b1
Reviewed-on: https://chromium-review.googlesource.com/c/1350414
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610782}

--

wpt-commits: a990dff8729c18279154f66650e83f01911216a4
wpt-pr: 14229

UltraBlame original commit: 3cee5ee7e89d121d039d5ddcca2bdf6a13010f8a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…butes to HTMLLinkElement, a=testonly

Automatic update from web-platform-tests
Add imageSrcset and imageSizes IDL attributes to HTMLLinkElement

This feature is behind the Experimental Web Platform feature flag.

Spec PR: whatwg/html#4048

Bug: 813452
Change-Id: I84c58035789b64a311637cebc4672d16661980c2
Reviewed-on: https://chromium-review.googlesource.com/c/1350558
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610990}

--

wpt-commits: dba9026fee0e7f5294181008a91b18c29030a397
wpt-pr: 14231

UltraBlame original commit: 050bf471d5cb823126cee83f31f3f78797e00867
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…o imagesrcset/imagesizes, a=testonly

Automatic update from web-platform-tests
Rename srcset/imgsizes link attributes to imagesrcset/imagesizes

This patch renames "srcset" and "imgsizes" attributes on link
to "imagesrcset" and "imagesizes" respectively, to match the latest
spec PR [1].

Note: this feature is behind experimental-web-platform-features flag.

[1] whatwg/html#4048

Bug: 813452
Change-Id: I8eabfbd734e2f29e36b7f7a3c4a32f1237b042b1
Reviewed-on: https://chromium-review.googlesource.com/c/1350414
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610782}

--

wpt-commits: a990dff8729c18279154f66650e83f01911216a4
wpt-pr: 14229

UltraBlame original commit: bb0ff9da601041924d15d595d43fcda992e9b17c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…butes to HTMLLinkElement, a=testonly

Automatic update from web-platform-tests
Add imageSrcset and imageSizes IDL attributes to HTMLLinkElement

This feature is behind the Experimental Web Platform feature flag.

Spec PR: whatwg/html#4048

Bug: 813452
Change-Id: I84c58035789b64a311637cebc4672d16661980c2
Reviewed-on: https://chromium-review.googlesource.com/c/1350558
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610990}

--

wpt-commits: dba9026fee0e7f5294181008a91b18c29030a397
wpt-pr: 14231

UltraBlame original commit: 988fb1f286accc0c15d9fc19410ed514598dfaf7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…o imagesrcset/imagesizes, a=testonly

Automatic update from web-platform-tests
Rename srcset/imgsizes link attributes to imagesrcset/imagesizes

This patch renames "srcset" and "imgsizes" attributes on link
to "imagesrcset" and "imagesizes" respectively, to match the latest
spec PR [1].

Note: this feature is behind experimental-web-platform-features flag.

[1] whatwg/html#4048

Bug: 813452
Change-Id: I8eabfbd734e2f29e36b7f7a3c4a32f1237b042b1
Reviewed-on: https://chromium-review.googlesource.com/c/1350414
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610782}

--

wpt-commits: a990dff8729c18279154f66650e83f01911216a4
wpt-pr: 14229

UltraBlame original commit: 3cee5ee7e89d121d039d5ddcca2bdf6a13010f8a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…butes to HTMLLinkElement, a=testonly

Automatic update from web-platform-tests
Add imageSrcset and imageSizes IDL attributes to HTMLLinkElement

This feature is behind the Experimental Web Platform feature flag.

Spec PR: whatwg/html#4048

Bug: 813452
Change-Id: I84c58035789b64a311637cebc4672d16661980c2
Reviewed-on: https://chromium-review.googlesource.com/c/1350558
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610990}

--

wpt-commits: dba9026fee0e7f5294181008a91b18c29030a397
wpt-pr: 14231

UltraBlame original commit: 050bf471d5cb823126cee83f31f3f78797e00867
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…o imagesrcset/imagesizes, a=testonly

Automatic update from web-platform-tests
Rename srcset/imgsizes link attributes to imagesrcset/imagesizes

This patch renames "srcset" and "imgsizes" attributes on link
to "imagesrcset" and "imagesizes" respectively, to match the latest
spec PR [1].

Note: this feature is behind experimental-web-platform-features flag.

[1] whatwg/html#4048

Bug: 813452
Change-Id: I8eabfbd734e2f29e36b7f7a3c4a32f1237b042b1
Reviewed-on: https://chromium-review.googlesource.com/c/1350414
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610782}

--

wpt-commits: a990dff8729c18279154f66650e83f01911216a4
wpt-pr: 14229

UltraBlame original commit: bb0ff9da601041924d15d595d43fcda992e9b17c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…butes to HTMLLinkElement, a=testonly

Automatic update from web-platform-tests
Add imageSrcset and imageSizes IDL attributes to HTMLLinkElement

This feature is behind the Experimental Web Platform feature flag.

Spec PR: whatwg/html#4048

Bug: 813452
Change-Id: I84c58035789b64a311637cebc4672d16661980c2
Reviewed-on: https://chromium-review.googlesource.com/c/1350558
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Reviewed-by: Kinuko Yasuda <kinukochromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Cr-Commit-Position: refs/heads/master{#610990}

--

wpt-commits: dba9026fee0e7f5294181008a91b18c29030a397
wpt-pr: 14231

UltraBlame original commit: 988fb1f286accc0c15d9fc19410ed514598dfaf7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Cr-Commit-Position: refs/heads/master{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127

UltraBlame original commit: 54dede13dc1253acdce7b200324c904cfe2a3fc1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Cr-Commit-Position: refs/heads/master{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127

UltraBlame original commit: 4c70421fcbab67e75f19743d9215abee07483f04
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Cr-Commit-Position: refs/heads/master{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127

UltraBlame original commit: 54dede13dc1253acdce7b200324c904cfe2a3fc1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Cr-Commit-Position: refs/heads/master{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127

UltraBlame original commit: 4c70421fcbab67e75f19743d9215abee07483f04
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Cr-Commit-Position: refs/heads/master{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127

UltraBlame original commit: 54dede13dc1253acdce7b200324c904cfe2a3fc1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…esrcset tests, a=testonly

Automatic update from web-platform-tests
Remove .tentative mark from preload-imagesrcset tests

Now that the HTML spec change (whatwg/html#4048)
is landed, let's remove the .tentative label from the tests.

Bug: 813452
Change-Id: Id92373c8b78b537b6020c6aa8e05765e2c075834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542738
Commit-Queue: Kunihiko Sakamoto <ksakamotochromium.org>
Reviewed-by: Dominic Farolino <domfarolinogmail.com>
Cr-Commit-Position: refs/heads/master{#645156}

--

wpt-commits: 835b267c69bfddefa374083edf408f1015145e27
wpt-pr: 16127

UltraBlame original commit: 4c70421fcbab67e75f19743d9215abee07483f04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation
10 participants