Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that credentials include HTTP auth #616

Merged
merged 3 commits into from
Oct 14, 2017

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Oct 13, 2017

Fixes #612.


Preview | Diff

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/credentials-clarification branch from 9c8039b to 7881dff Compare October 13, 2017 06:04
@annevk
Copy link
Member

annevk commented Oct 13, 2017

I think it would be better if instead of clarifying it here, we clarified in "authentication entries" that they are for HTTP authentication. Otherwise there's still the lack of clarity there.

@annevk
Copy link
Member

annevk commented Oct 13, 2017

That used to be clearer since there was just a link to HTTP authentication I believe, but that got muddled somewhat at some point.

@sideshowbarker
Copy link
Contributor Author

I think it would be better if instead of clarifying it here, we clarified in "authentication entries" that they are for HTTP authentication. Otherwise there's still the lack of clarity there.

OK I but it doesn’t need to be an either-or thing. I mean, I think it’s helpful to mention HTTP authentication as part of the credentials definition, at point of use — without requiring readers to need to go to the authentication entries definition to realize it’s about HTTP authentication.

But I can also update the authentication entries definition to make it more clear it’s about HTTP authentication.

And anyway I think to begin with the benefit of any changes here are for non-implementor readers, and not really for implementors. So I think if we’re going to add anything more here at all over what’s in the spec already now, it sort of should be optimized/targeted for non-implementor readers.

@annevk
Copy link
Member

annevk commented Oct 13, 2017

Okay, I could live with a "(for HTTP authentication)" after "authentication entries" as well as the additional references which seem useful either way.

fetch.bs Outdated

<p>An <dfn export>authentication entry</dfn> and a <dfn export>proxy-authentication entry</dfn> are
tuples of username, password, and realm, used for HTTP authentication, and associated with one or
more <a for=/>requests</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing dot went missing. Also, I'd make it "HTTP and HTTP proxy authentication" maybe?

@annevk annevk merged commit d84658e into master Oct 14, 2017
@annevk annevk deleted the sideshowbarker/credentials-clarification branch October 14, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants