Suggest permission lifetimes #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
approved these changes
Nov 11, 2021
marcoscaceres
commented
Nov 15, 2021
marcoscaceres
commented
Nov 15, 2021
reillyeon
approved these changes
Nov 15, 2021
samuelweiler
approved these changes
Nov 15, 2021
jyasskin
reviewed
Nov 16, 2021
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
marcoscaceres
force-pushed
the
lifetimes
branch
from
522c055
to
d86891b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
Closes #54
Depends on w3c/permissions#287 and whatwg/html#7337
Try to be broadly accommodating to what browses do with respect to Geolocation permission lifetimes. I prioritized "single session" permissions, while accommodating what Chrome does (you can navigate around... only when you close the browser window/tab does it reset). I also allowed for what Brave does (time based).
The following tasks have been completed:
Modified Web platform tests(not testable)Implementation commitment:
Preview | Diff