Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 0 when watchPosition() errors #100

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Return 0 when watchPosition() errors #100

merged 1 commit into from
Jul 30, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 29, 2021 •
edited by pr-preview bot
Loading

Closes #95 - @reillyeon, please see #95 (comment) for rationale for change.

The following tasks have been completed:

Implementation commitment:

  • WebKit - already returns 0.
  • Chromium - already returns 0.
  • Gecko

Preview | Diff
@marcoscaceres
Copy link
Member Author

This change is included in test web-platform-tests/wpt#29799
reillyeon
reillyeon approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly you can check off implementation commitment from WebKit and Chromium as they already implement this behavior.
@marcoscaceres
Copy link
Member Author

If I understand correctly you can check off implementation commitment from WebKit and Chromium as they already implement this behavior.

They implement the returning 0 part, yes - but not the "fully active" aspect of #78... so, to use a dated Simpsons reference, "partial credit" :)
@marcoscaceres marcoscaceres merged commit 2c0c516 into gh-pages Jul 30, 2021
@marcoscaceres marcoscaceres deleted the error_code branch July 30, 2021 01:26
@marcoscaceres marcoscaceres mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@marcoscaceres @reillyeon