[css-flexbox] Clarify implied minimum size definition #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#671. In the [old version](https://hg.csswg.org/drafts/rev/25641c92d33f) this case was specified, but dropped while changing from a table to a paragraph. r? @dbaron
|
Er, the github notification I got pointed to a commit in Shing's repository and gave me no hint whatsoever that the comment I made on the commit would show up as a comment on a pull request in a different repository, or even that such a pull request existed! So, anyway, /cc @tabatkins |
|
From my side, the comment shows up in both my fork and this PR. |
|
It wasn't intentionally dropped; it was intended that this was covered by the first clause - the min() of a value and something that doesn't exist is the value. That said, I have nothing against making this more explicit. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671. In the old version this case was specified, but dropped while changing from a table to a paragraph.
r? @dbaron