Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): storeToRefs with nested refs #2659

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

quiteeasy
Copy link

@quiteeasy quiteeasy commented Apr 29, 2024

Close #2658

Fix: Return type of storeToRefs doesn't match runtime result if values are nested computed values #2658

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit 2b1b80a
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/662fe3ffb407320007aaca3a
😎 Deploy Preview https://deploy-preview-2659--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 2b1b80a
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/662fe3ff16fcd90008f84245
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
After updating locally and adding a test, it doesn't seem to be fixed 🤔
can you rebase from v2 branch and add a test to ensure this works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants