Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds a transient button component #8629

Merged
merged 13 commits into from
Jul 6, 2024

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Mar 5, 2024

Description

Adds a TransientButton component for the types of button that are shown on top of the video briefly during playback and reappear when there is user activity. e.g. Unmute buttons, skip intro. It aims is to be a generic button type to be extended. Some basic styles are provided but kept light to not complicate customisation.
It's important to insert a transient button before the control bar for the tab order to make sense.

Optionally takes focus when shown.

Specific Changes proposed

Adds TransientButton component.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (f701102) to head (f04178c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8629      +/-   ##
==========================================
+ Coverage   83.01%   83.06%   +0.05%     
==========================================
  Files         119      120       +1     
  Lines        7993     8021      +28     
  Branches     1923     1924       +1     
==========================================
+ Hits         6635     6663      +28     
  Misses       1358     1358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/js/transient-button.js Outdated Show resolved Hide resolved
@mister-ben mister-ben marked this pull request as ready for review June 18, 2024 14:40
@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Jul 4, 2024
Copy link
Contributor

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mister-ben mister-ben merged commit 1afe504 into videojs:main Jul 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
3 participants