Adds missing dependency #9453
Merged
Adds missing dependency #9453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
Timer
approved these changes
Nov 19, 2019
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| buildDuration | 13.3s | 13.4s | |
| nodeModulesSize | 48.3 MB | 48.3 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| main-HASH.js | 14.8 kB | 14.8 kB | ✓ |
| main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..0f1a45b52.js | 19.9 kB | 19.9 kB | ✓ |
| 16b1a7225520..5b52.js gzip | 7.34 kB | 7.34 kB | ✓ |
| 314e4c089430..de6eb480f.js | 7.9 kB | 7.9 kB | ✓ |
| 314e4c089430..480f.js gzip | 3.31 kB | 3.31 kB | ✓ |
| commons.HASH.js | 10.4 kB | 10.4 kB | ✓ |
| commons.HASH.js gzip | 3.91 kB | 3.91 kB | ✓ |
| de003c3a9d30..39988e4af.js | 33.1 kB | 33.1 kB | ✓ |
| de003c3a9d30..e4af.js gzip | 12.3 kB | 12.3 kB | ✓ |
| framework.HASH.js | 125 kB | 125 kB | ✓ |
| framework.HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 213 kB | 213 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| main-HASH.module.js | 14.1 kB | 14.1 kB | ✓ |
| main-HASH.module.js gzip | 5.29 kB | 5.29 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..99.module.js | 16.1 kB | 16.1 kB | ✓ |
| 16b1a7225520..dule.js gzip | 6.22 kB | 6.22 kB | ✓ |
| 4952ddcd88e7..cc.module.js | 11.9 kB | 11.9 kB | ✓ |
| 4952ddcd88e7..dule.js gzip | 4.43 kB | 4.43 kB | ✓ |
| de003c3a9d30..36.module.js | 22.2 kB | 22.2 kB | ✓ |
| de003c3a9d30..dule.js gzip | 8.71 kB | 8.71 kB | ✓ |
| framework.HASH.module.js | 125 kB | 125 kB | ✓ |
| framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 191 kB | 191 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| polyfills-HASH.js | 9.11 kB | 9.11 kB | ✓ |
| polyfills-HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
| Overall change | 9.11 kB | 9.11 kB | ✓ |
Client Pages
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _app.js | 7.71 kB | 7.71 kB | ✓ |
| _app.js gzip | 3.22 kB | 3.22 kB | ✓ |
| _error.js | 14.9 kB | 14.9 kB | ✓ |
| _error.js gzip | 5.57 kB | 5.57 kB | ✓ |
| hooks.js | 1.92 kB | 1.92 kB | ✓ |
| hooks.js gzip | 941 B | 941 B | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 4.05 kB | 4.05 kB | ✓ |
| link.js gzip | 1.81 kB | 1.81 kB | ✓ |
| routerDirect.js | 411 B | 411 B | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js | 421 B | 421 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 29.7 kB | 29.7 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _app.module.js | 1.54 kB | 1.54 kB | ✓ |
| _app.module.js gzip | 759 B | 759 B | ✓ |
| _error.module.js | 10.5 kB | 10.5 kB | ✓ |
| _error.module.js gzip | 4.26 kB | 4.26 kB | ✓ |
| hooks.module.js | 677 B | 677 B | ✓ |
| hooks.module.js gzip | 384 B | 384 B | ✓ |
| index.module.js | 292 B | 292 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 5.49 kB | 5.49 kB | ✓ |
| link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
| routerDirect.module.js | 399 B | 399 B | ✓ |
| routerDirect..dule.js gzip | 285 B | 285 B | ✓ |
| withRouter.module.js | 409 B | 409 B | ✓ |
| withRouter.m..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 19.3 kB | 19.3 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _buildManifest.js | 353 B | 353 B | ✓ |
| _buildManifest.js gzip | 259 B | 259 B | ✓ |
| _buildManifest.module.js | 251 B | 251 B | ✓ |
| _buildManife..dule.js gzip | 205 B | 205 B | ✓ |
| Overall change | 604 B | 604 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| index.html | 3.9 kB | 3.9 kB | ✓ |
| index.html gzip | 1.02 kB | 1.02 kB | ✓ |
| link.html | 4.58 kB | 4.58 kB | ✓ |
| link.html gzip | 1.14 kB | 1.14 kB | ✓ |
| withRouter.html | 4.43 kB | 4.43 kB | ✓ |
| withRouter.html gzip | 1.08 kB | 1.08 kB | ✓ |
| Overall change | 12.9 kB | 12.9 kB | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| buildDuration | 13.7s | 13.7s | -17ms |
| nodeModulesSize | 48.3 MB | 48.3 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| main-HASH.js | 14.8 kB | 14.8 kB | ✓ |
| main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..0f1a45b52.js | 19.9 kB | 19.9 kB | ✓ |
| 16b1a7225520..5b52.js gzip | 7.34 kB | 7.34 kB | ✓ |
| 314e4c089430..de6eb480f.js | 7.9 kB | 7.9 kB | ✓ |
| 314e4c089430..480f.js gzip | 3.31 kB | 3.31 kB | ✓ |
| commons.HASH.js | 10.4 kB | 10.4 kB | ✓ |
| commons.HASH.js gzip | 3.91 kB | 3.91 kB | ✓ |
| de003c3a9d30..39988e4af.js | 33.1 kB | 33.1 kB | ✓ |
| de003c3a9d30..e4af.js gzip | 12.3 kB | 12.3 kB | ✓ |
| framework.HASH.js | 125 kB | 125 kB | ✓ |
| framework.HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 213 kB | 213 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| main-HASH.module.js | 14.1 kB | 14.1 kB | ✓ |
| main-HASH.module.js gzip | 5.29 kB | 5.29 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..99.module.js | 16.1 kB | 16.1 kB | ✓ |
| 16b1a7225520..dule.js gzip | 6.22 kB | 6.22 kB | ✓ |
| 4952ddcd88e7..cc.module.js | 11.9 kB | 11.9 kB | ✓ |
| 4952ddcd88e7..dule.js gzip | 4.43 kB | 4.43 kB | ✓ |
| de003c3a9d30..36.module.js | 22.2 kB | 22.2 kB | ✓ |
| de003c3a9d30..dule.js gzip | 8.71 kB | 8.71 kB | ✓ |
| framework.HASH.module.js | 125 kB | 125 kB | ✓ |
| framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 191 kB | 191 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| polyfills-HASH.js | 9.11 kB | 9.11 kB | ✓ |
| polyfills-HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
| Overall change | 9.11 kB | 9.11 kB | ✓ |
Client Pages
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _app.js | 7.71 kB | 7.71 kB | ✓ |
| _app.js gzip | 3.22 kB | 3.22 kB | ✓ |
| _error.js | 14.9 kB | 14.9 kB | ✓ |
| _error.js gzip | 5.57 kB | 5.57 kB | ✓ |
| hooks.js | 1.92 kB | 1.92 kB | ✓ |
| hooks.js gzip | 941 B | 941 B | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 4.05 kB | 4.05 kB | ✓ |
| link.js gzip | 1.81 kB | 1.81 kB | ✓ |
| routerDirect.js | 411 B | 411 B | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js | 421 B | 421 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 29.7 kB | 29.7 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _app.module.js | 1.54 kB | 1.54 kB | ✓ |
| _app.module.js gzip | 759 B | 759 B | ✓ |
| _error.module.js | 10.5 kB | 10.5 kB | ✓ |
| _error.module.js gzip | 4.26 kB | 4.26 kB | ✓ |
| hooks.module.js | 677 B | 677 B | ✓ |
| hooks.module.js gzip | 384 B | 384 B | ✓ |
| index.module.js | 292 B | 292 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 5.49 kB | 5.49 kB | ✓ |
| link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
| routerDirect.module.js | 399 B | 399 B | ✓ |
| routerDirect..dule.js gzip | 285 B | 285 B | ✓ |
| withRouter.module.js | 409 B | 409 B | ✓ |
| withRouter.m..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 19.3 kB | 19.3 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _buildManifest.js | 353 B | 353 B | ✓ |
| _buildManifest.js gzip | 259 B | 259 B | ✓ |
| _buildManifest.module.js | 251 B | 251 B | ✓ |
| _buildManife..dule.js gzip | 205 B | 205 B | ✓ |
| Overall change | 604 B | 604 B | ✓ |
Serverless bundles
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _error.js | 241 kB | 241 kB | ✓ |
| _error.js gzip | 64.5 kB | 64.5 kB | ✓ |
| hooks.html | 4.04 kB | 4.04 kB | ✓ |
| hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
| index.js | 242 kB | 242 kB | ✓ |
| index.js gzip | 64.6 kB | 64.6 kB | ✓ |
| link.js | 274 kB | 274 kB | ✓ |
| link.js gzip | 73.6 kB | 73.6 kB | ✓ |
| routerDirect.js | 267 kB | 267 kB | ✓ |
| routerDirect.js gzip | 71.6 kB | 71.6 kB | ✓ |
| withRouter.js | 267 kB | 267 kB | ✓ |
| withRouter.js gzip | 71.7 kB | 71.7 kB | ✓ |
| Overall change | 1.29 MB | 1.29 MB | ✓ |
Commit: 2088599
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| buildDuration | 13.8s | 14.3s | |
| nodeModulesSize | 48.3 MB | 48.3 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| main-HASH.js | 14.8 kB | 14.8 kB | ✓ |
| main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..0f1a45b52.js | 19.9 kB | 19.9 kB | ✓ |
| 16b1a7225520..5b52.js gzip | 7.34 kB | 7.34 kB | ✓ |
| 314e4c089430..de6eb480f.js | 7.9 kB | 7.9 kB | ✓ |
| 314e4c089430..480f.js gzip | 3.31 kB | 3.31 kB | ✓ |
| commons.HASH.js | 10.4 kB | 10.4 kB | ✓ |
| commons.HASH.js gzip | 3.91 kB | 3.91 kB | ✓ |
| de003c3a9d30..39988e4af.js | 33.1 kB | 33.1 kB | ✓ |
| de003c3a9d30..e4af.js gzip | 12.3 kB | 12.3 kB | ✓ |
| framework.HASH.js | 125 kB | 125 kB | ✓ |
| framework.HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 213 kB | 213 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| main-HASH.module.js | 14.1 kB | 14.1 kB | ✓ |
| main-HASH.module.js gzip | 5.29 kB | 5.29 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..99.module.js | 16.1 kB | 16.1 kB | ✓ |
| 16b1a7225520..dule.js gzip | 6.22 kB | 6.22 kB | ✓ |
| 4952ddcd88e7..cc.module.js | 11.9 kB | 11.9 kB | ✓ |
| 4952ddcd88e7..dule.js gzip | 4.43 kB | 4.43 kB | ✓ |
| de003c3a9d30..36.module.js | 22.2 kB | 22.2 kB | ✓ |
| de003c3a9d30..dule.js gzip | 8.71 kB | 8.71 kB | ✓ |
| framework.HASH.module.js | 125 kB | 125 kB | ✓ |
| framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 191 kB | 191 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| polyfills-HASH.js | 9.11 kB | 9.11 kB | ✓ |
| polyfills-HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
| Overall change | 9.11 kB | 9.11 kB | ✓ |
Client Pages
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _app.js | 7.71 kB | 7.71 kB | ✓ |
| _app.js gzip | 3.22 kB | 3.22 kB | ✓ |
| _error.js | 14.9 kB | 14.9 kB | ✓ |
| _error.js gzip | 5.57 kB | 5.57 kB | ✓ |
| hooks.js | 1.92 kB | 1.92 kB | ✓ |
| hooks.js gzip | 941 B | 941 B | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 4.05 kB | 4.05 kB | ✓ |
| link.js gzip | 1.81 kB | 1.81 kB | ✓ |
| routerDirect.js | 411 B | 411 B | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js | 421 B | 421 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 29.7 kB | 29.7 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _app.module.js | 1.54 kB | 1.54 kB | ✓ |
| _app.module.js gzip | 759 B | 759 B | ✓ |
| _error.module.js | 10.5 kB | 10.5 kB | ✓ |
| _error.module.js gzip | 4.26 kB | 4.26 kB | ✓ |
| hooks.module.js | 677 B | 677 B | ✓ |
| hooks.module.js gzip | 384 B | 384 B | ✓ |
| index.module.js | 292 B | 292 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 5.49 kB | 5.49 kB | ✓ |
| link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
| routerDirect.module.js | 399 B | 399 B | ✓ |
| routerDirect..dule.js gzip | 285 B | 285 B | ✓ |
| withRouter.module.js | 409 B | 409 B | ✓ |
| withRouter.m..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 19.3 kB | 19.3 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _buildManifest.js | 353 B | 353 B | ✓ |
| _buildManifest.js gzip | 259 B | 259 B | ✓ |
| _buildManifest.module.js | 251 B | 251 B | ✓ |
| _buildManife..dule.js gzip | 205 B | 205 B | ✓ |
| Overall change | 604 B | 604 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| index.html | 3.9 kB | 3.9 kB | ✓ |
| index.html gzip | 1.02 kB | 1.02 kB | ✓ |
| link.html | 4.58 kB | 4.58 kB | ✓ |
| link.html gzip | 1.14 kB | 1.14 kB | ✓ |
| withRouter.html | 4.43 kB | 4.43 kB | ✓ |
| withRouter.html gzip | 1.08 kB | 1.08 kB | ✓ |
| Overall change | 12.9 kB | 12.9 kB | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| buildDuration | 14.4s | 14.3s | -43ms |
| nodeModulesSize | 48.3 MB | 48.3 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| main-HASH.js | 14.8 kB | 14.8 kB | ✓ |
| main-HASH.js gzip | 5.11 kB | 5.11 kB | ✓ |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..0f1a45b52.js | 19.9 kB | 19.9 kB | ✓ |
| 16b1a7225520..5b52.js gzip | 7.34 kB | 7.34 kB | ✓ |
| 314e4c089430..de6eb480f.js | 7.9 kB | 7.9 kB | ✓ |
| 314e4c089430..480f.js gzip | 3.31 kB | 3.31 kB | ✓ |
| commons.HASH.js | 10.4 kB | 10.4 kB | ✓ |
| commons.HASH.js gzip | 3.91 kB | 3.91 kB | ✓ |
| de003c3a9d30..39988e4af.js | 33.1 kB | 33.1 kB | ✓ |
| de003c3a9d30..e4af.js gzip | 12.3 kB | 12.3 kB | ✓ |
| framework.HASH.js | 125 kB | 125 kB | ✓ |
| framework.HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 213 kB | 213 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| main-HASH.module.js | 14.1 kB | 14.1 kB | ✓ |
| main-HASH.module.js gzip | 5.29 kB | 5.29 kB | ✓ |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| 16b1a7225520..99.module.js | 16.1 kB | 16.1 kB | ✓ |
| 16b1a7225520..dule.js gzip | 6.22 kB | 6.22 kB | ✓ |
| 4952ddcd88e7..cc.module.js | 11.9 kB | 11.9 kB | ✓ |
| 4952ddcd88e7..dule.js gzip | 4.43 kB | 4.43 kB | ✓ |
| de003c3a9d30..36.module.js | 22.2 kB | 22.2 kB | ✓ |
| de003c3a9d30..dule.js gzip | 8.71 kB | 8.71 kB | ✓ |
| framework.HASH.module.js | 125 kB | 125 kB | ✓ |
| framework.HA..dule.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 191 kB | 191 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| polyfills-HASH.js | 9.11 kB | 9.11 kB | ✓ |
| polyfills-HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
| Overall change | 9.11 kB | 9.11 kB | ✓ |
Client Pages
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _app.js | 7.71 kB | 7.71 kB | ✓ |
| _app.js gzip | 3.22 kB | 3.22 kB | ✓ |
| _error.js | 14.9 kB | 14.9 kB | ✓ |
| _error.js gzip | 5.57 kB | 5.57 kB | ✓ |
| hooks.js | 1.92 kB | 1.92 kB | ✓ |
| hooks.js gzip | 941 B | 941 B | ✓ |
| index.js | 318 B | 318 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js | 4.05 kB | 4.05 kB | ✓ |
| link.js gzip | 1.81 kB | 1.81 kB | ✓ |
| routerDirect.js | 411 B | 411 B | ✓ |
| routerDirect.js gzip | 283 B | 283 B | ✓ |
| withRouter.js | 421 B | 421 B | ✓ |
| withRouter.js gzip | 282 B | 282 B | ✓ |
| Overall change | 29.7 kB | 29.7 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _app.module.js | 1.54 kB | 1.54 kB | ✓ |
| _app.module.js gzip | 759 B | 759 B | ✓ |
| _error.module.js | 10.5 kB | 10.5 kB | ✓ |
| _error.module.js gzip | 4.26 kB | 4.26 kB | ✓ |
| hooks.module.js | 677 B | 677 B | ✓ |
| hooks.module.js gzip | 384 B | 384 B | ✓ |
| index.module.js | 292 B | 292 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js | 5.49 kB | 5.49 kB | ✓ |
| link.module.js gzip | 2.47 kB | 2.47 kB | ✓ |
| routerDirect.module.js | 399 B | 399 B | ✓ |
| routerDirect..dule.js gzip | 285 B | 285 B | ✓ |
| withRouter.module.js | 409 B | 409 B | ✓ |
| withRouter.m..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 19.3 kB | 19.3 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _buildManifest.js | 353 B | 353 B | ✓ |
| _buildManifest.js gzip | 259 B | 259 B | ✓ |
| _buildManifest.module.js | 251 B | 251 B | ✓ |
| _buildManife..dule.js gzip | 205 B | 205 B | ✓ |
| Overall change | 604 B | 604 B | ✓ |
Serverless bundles
| zeit/next.js canary | arcanis/next.js patch-2 | Change | |
|---|---|---|---|
| _error.js | 241 kB | 241 kB | ✓ |
| _error.js gzip | 64.5 kB | 64.5 kB | ✓ |
| hooks.html | 4.04 kB | 4.04 kB | ✓ |
| hooks.html gzip | 1.05 kB | 1.05 kB | ✓ |
| index.js | 242 kB | 242 kB | ✓ |
| index.js gzip | 64.6 kB | 64.6 kB | ✓ |
| link.js | 274 kB | 274 kB | ✓ |
| link.js gzip | 73.6 kB | 73.6 kB | ✓ |
| routerDirect.js | 267 kB | 267 kB | ✓ |
| routerDirect.js gzip | 71.6 kB | 71.6 kB | ✓ |
| withRouter.js | 267 kB | 267 kB | ✓ |
| withRouter.js gzip | 71.7 kB | 71.7 kB | ✓ |
| Overall change | 1.29 MB | 1.29 MB | ✓ |
Commit: e413928
|
Thanks for catching this and the PR! |
Timer
added a commit
to Timer/berry
that referenced
this pull request
Nov 19, 2019
This upgrades the workflow's Next.js version to the latest canary. This canary includes the fix landed in vercel/next.js#9453.
|
@arcanis I've returned the favor yarnpkg/berry#591 🙏 |
arcanis
pushed a commit
to yarnpkg/berry
that referenced
this pull request
Nov 19, 2019
This upgrades the workflow's Next.js version to the latest canary. This canary includes the fix landed in vercel/next.js#9453.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9369 added a reference to
object-assign, butobject-assignisn't a dependency of the project so you have no guarantee regarding the version you'll get (maybe the react one will be hoisted, maybe another, maybe neither).Detected this because the Yarn Next.js E2E started to fail:
https://github.com/yarnpkg/berry/runs/309172981