Remove React Suspense from Client Runtime #8887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer
added
Type: Bug
Upstream
timneutkens
approved these changes
Sep 28, 2019
Kristonitas
reviewed
Sep 28, 2019
| @@ -0,0 +1,19 @@ | |||
| import React, { Suspense } from 'react' | |||
There was a problem hiding this comment.
What is this test covering, isn't Suspense failing?
P. S. I'm completely new to next.js, let alone its development.
There was a problem hiding this comment.
The data folder covers an experimental feature we've been developing, it's unrelated to anything else.
|
@devknoll FYI on these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
<Suspense>component from Next.js' client-side runtime to deal with a breaking change released in a React minor version.Closes #8886