Update to replace asPath for static pages in dev mode #8388

ijjk · 2019-08-16T05:38:22Z

If a user relies on the asPath in an auto prerendered page it can cause a hydration error. This error isn't noticed in dev mode since we don't replace the asPath in dev mode with the value that will be there during auto prerendering.

This updates that and adds a test to make sure we don't regress on it

ijjk · 2019-08-16T05:45:21Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
buildDuration	23.6s	23.6s	-23ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +57 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
link	2.8 kB	2.8 kB	✓
link gzip	848 B	850 B	⚠️ +2 B
index	2.75 kB	2.75 kB	✓
index gzip	838 B	841 B	⚠️ +3 B
withRouter	2.81 kB	2.81 kB	✓
withRouter gzip	836 B	839 B	⚠️ +3 B
Overall change			✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
buildDuration	24.7s	24.7s	⚠️ +62ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +57 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.27 kB	-1 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	601 B	⚠️ +1 B
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	-1 B
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	289 B	-1 B
Overall change			✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_error.js	247 kB	247 kB	⚠️ +32 B
_error.js gzip	66.3 kB	66.3 kB	⚠️ +7 B
hooks.html	2.87 kB	2.87 kB	✓
hooks.html gzip	864 B	864 B	✓
index.js	248 kB	248 kB	⚠️ +32 B
index.js gzip	66.6 kB	66.6 kB	⚠️ +6 B
link.js	255 kB	255 kB	⚠️ +32 B
link.js gzip	68.8 kB	68.8 kB	⚠️ +7 B
routerDirect.js	248 kB	248 kB	⚠️ +32 B
routerDirect.js gzip	66.5 kB	66.5 kB	⚠️ +6 B
withRouter.js	248 kB	248 kB	⚠️ +32 B
withRouter.js gzip	66.6 kB	66.6 kB	⚠️ +6 B
Overall change			⚠️ +160 B

ijjk · 2019-08-16T06:21:14Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
buildDuration	24.6s	25s	⚠️ +452ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +57 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.27 kB	6.28 kB	⚠️ +1 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	601 B	600 B	-1 B
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	⚠️ +1 B
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	289 B	290 B	⚠️ +1 B
Overall change			✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
link	2.8 kB	2.8 kB	✓
link gzip	849 B	850 B	⚠️ +1 B
index	2.75 kB	2.75 kB	✓
index gzip	841 B	838 B	-3 B
withRouter	2.81 kB	2.81 kB	✓
withRouter gzip	836 B	838 B	⚠️ +2 B
Overall change			✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
buildDuration	25.9s	26s	⚠️ +141ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +57 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_error.js	247 kB	247 kB	⚠️ +32 B
_error.js gzip	66.3 kB	66.3 kB	⚠️ +7 B
hooks.html	2.87 kB	2.87 kB	✓
hooks.html gzip	866 B	866 B	✓
index.js	248 kB	248 kB	⚠️ +32 B
index.js gzip	66.6 kB	66.6 kB	⚠️ +6 B
link.js	255 kB	255 kB	⚠️ +32 B
link.js gzip	68.8 kB	68.8 kB	⚠️ +7 B
routerDirect.js	248 kB	248 kB	⚠️ +32 B
routerDirect.js gzip	66.5 kB	66.5 kB	⚠️ +7 B
withRouter.js	248 kB	248 kB	⚠️ +32 B
withRouter.js gzip	66.6 kB	66.6 kB	⚠️ +7 B
Overall change			⚠️ +160 B

timneutkens · 2019-08-16T11:13:47Z

test/integration/auto-export/pages/[post]/[cmnt].js

+export default () => {
+  const { query, asPath } = useRouter()
+  const { cmnt } = query
+  return <p>{cmnt || asPath}</p>


This test seems pretty hard to understand, can't you add 2 fields instead?

This is testing that the hydration warning shows in development when asPath is used on an auto-prerendered dynamic-route. I simplified it down to <p>{useRouter().asPath}</p> since that's the main thing being tested.

We could also take it a step further and prevent the hydration from breaking by having asPath match the auto-prerendered value during CSR and update it when we parse the dynamic values on mount

…thname

ijjk · 2019-08-16T15:46:48Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
buildDuration	22.8s	22.8s	⚠️ +40ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +57 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
link	2.8 kB	2.8 kB	✓
link gzip	851 B	851 B	✓
index	2.75 kB	2.75 kB	✓
index gzip	843 B	843 B	✓
withRouter	2.81 kB	2.81 kB	✓
withRouter gzip	839 B	839 B	✓
Overall change			✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
buildDuration	24.4s	24.6s	⚠️ +178ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +57 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.27 kB	-1 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	601 B	⚠️ +1 B
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	-1 B
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	289 B	-1 B
Overall change			✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_error.js	247 kB	247 kB	⚠️ +32 B
_error.js gzip	66.3 kB	66.3 kB	⚠️ +7 B
hooks.html	2.87 kB	2.87 kB	✓
hooks.html gzip	866 B	866 B	✓
index.js	248 kB	248 kB	⚠️ +32 B
index.js gzip	66.6 kB	66.6 kB	⚠️ +8 B
link.js	255 kB	255 kB	⚠️ +32 B
link.js gzip	68.8 kB	68.8 kB	⚠️ +7 B
routerDirect.js	248 kB	248 kB	⚠️ +32 B
routerDirect.js gzip	66.5 kB	66.5 kB	⚠️ +7 B
withRouter.js	248 kB	248 kB	⚠️ +32 B
withRouter.js gzip	66.6 kB	66.6 kB	⚠️ +6 B
Overall change			⚠️ +160 B

ijjk · 2019-08-16T16:34:02Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
buildDuration	23.4s	23.5s	⚠️ +87ms
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +57 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Fetched pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
link	2.8 kB	2.8 kB	✓
link gzip	850 B	850 B	✓
index	2.75 kB	2.75 kB	✓
index gzip	842 B	843 B	⚠️ +1 B
withRouter	2.81 kB	2.81 kB	✓
withRouter gzip	838 B	839 B	⚠️ +1 B
Overall change			✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
buildDuration	24.6s	26s	⚠️ +1.4s
nodeModulesSize	41.3 MB	41.3 MB	⚠️ +57 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.js	17.9 kB	17.9 kB	✓
main-HASH.js gzip	6.56 kB	6.56 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
commons.HASH.js	190 kB	190 kB	✓
commons.HASH.js gzip	61.6 kB	61.6 kB	✓
Overall change			✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
main-HASH.module.js	16.2 kB	16.2 kB	✓
main-HASH.module.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH.module.js gzip	746 B	746 B	✓
commons.HASH.module.js	171 kB	171 kB	✓
commons.HASH.module.js gzip	55.4 kB	55.4 kB	✓
Overall change			✓

Client Pages

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.js	1.9 kB	1.9 kB	✓
_app.js gzip	905 B	905 B	✓
_error.js	12.1 kB	12.1 kB	✓
_error.js gzip	4.76 kB	4.76 kB	✓
hooks.js	1.06 kB	1.06 kB	✓
hooks.js gzip	600 B	600 B	✓
index.js	343 B	343 B	✓
index.js gzip	237 B	237 B	✓
link.js	8.13 kB	8.13 kB	✓
link.js gzip	3.49 kB	3.49 kB	✓
routerDirect.js	429 B	429 B	✓
routerDirect.js gzip	292 B	292 B	✓
withRouter.js	439 B	439 B	✓
withRouter.js gzip	290 B	290 B	✓
Overall change			✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_app.module.js	1.79 kB	1.79 kB	✓
_app.module.js gzip	865 B	865 B	✓
_error.module.js	10.6 kB	10.6 kB	✓
_error.module.js gzip	4.31 kB	4.31 kB	✓
hooks.module.js	596 B	596 B	✓
hooks.module.js gzip	354 B	354 B	✓
index.module.js	319 B	319 B	✓
index.module.js gzip	238 B	238 B	✓
link.module.js	8.52 kB	8.52 kB	✓
link.module.js gzip	3.67 kB	3.67 kB	✓
routerDirect.module.js	417 B	417 B	✓
routerDirect.module.js gzip	292 B	292 B	✓
withRouter.module.js	427 B	427 B	✓
withRouter.module.js gzip	291 B	291 B	✓
Overall change			✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js auto-prerender-pathname	Change
_error.js	247 kB	247 kB	⚠️ +32 B
_error.js gzip	66.3 kB	66.3 kB	⚠️ +5 B
hooks.html	2.87 kB	2.87 kB	✓
hooks.html gzip	866 B	864 B	-2 B
index.js	248 kB	248 kB	⚠️ +32 B
index.js gzip	66.6 kB	66.6 kB	⚠️ +5 B
link.js	255 kB	255 kB	⚠️ +32 B
link.js gzip	68.8 kB	68.8 kB	⚠️ +5 B
routerDirect.js	248 kB	248 kB	⚠️ +32 B
routerDirect.js gzip	66.5 kB	66.5 kB	⚠️ +6 B
withRouter.js	248 kB	248 kB	⚠️ +32 B
withRouter.js gzip	66.6 kB	66.6 kB	⚠️ +5 B
Overall change			⚠️ +160 B

Timer · 2019-08-16T16:36:58Z

No size increase, this is server only code.

Update to replace asPath for static pages in dev mode

b5593c4

ijjk requested review from lfades, Timer and timneutkens as code owners August 16, 2019 05:38

Run lint-fix

c358d54

timneutkens reviewed Aug 16, 2019

View reviewed changes

ijjk added 2 commits August 16, 2019 10:30

Merge remote-tracking branch 'upstream/canary' into auto-prerender-pa…

49b76f9

…thname

Simplify test a bit

f83bc6a

Timer approved these changes Aug 16, 2019

View reviewed changes

Merge branch 'canary' into auto-prerender-pathname

082dbb5

Timer added this to the 9.0.4 milestone Aug 16, 2019

Timer added ready to land labels Aug 16, 2019

Timer merged commit 5422ee0 into vercel:canary Aug 16, 2019

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to replace asPath for static pages in dev mode #8388

Update to replace asPath for static pages in dev mode #8388

ijjk commented Aug 16, 2019

ijjk commented Aug 16, 2019

ijjk commented Aug 16, 2019

timneutkens Aug 16, 2019

ijjk Aug 16, 2019

ijjk commented Aug 16, 2019

ijjk commented Aug 16, 2019

Timer commented Aug 16, 2019

Update to replace asPath for static pages in dev mode #8388

Update to replace asPath for static pages in dev mode #8388

Conversation

ijjk commented Aug 16, 2019

ijjk commented Aug 16, 2019

Stats from current PR

ijjk commented Aug 16, 2019

Stats from current PR

timneutkens Aug 16, 2019

Choose a reason for hiding this comment

ijjk Aug 16, 2019

Choose a reason for hiding this comment

ijjk commented Aug 16, 2019

Stats from current PR

ijjk commented Aug 16, 2019

Stats from current PR

Timer commented Aug 16, 2019