Reverting clear measure #8373
Merged
Reverting clear measure #8373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekbh
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| buildDuration | 20.8s | 20.4s | -349ms |
| nodeModulesSize | 41.3 MB | 41.5 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| main-HASH.js | 13.8 kB | 13.8 kB | -41 B |
| main-HASH.js gzip | 4.87 kB | 4.85 kB | -16 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.js | 194 kB | 194 kB | -135 B |
| commons.HASH.js gzip | 63.1 kB | 63.1 kB | -26 B |
| Overall change | -176 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| main-HASH.module.js | 11.4 kB | 11.4 kB | -41 B |
| main-HASH.module.js gzip | 4.31 kB | 4.29 kB | -16 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.module.js | 176 kB | 175 kB | -110 B |
| commons.HASH.module.js gzip | 57.2 kB | 57.1 kB | -22 B |
| Overall change | -151 B |
Client Pages
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 905 B | 905 B | ✓ |
| _error.js | 8.02 kB | 8.02 kB | ✓ |
| _error.js gzip | 3.12 kB | 3.12 kB | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 4.07 kB | 4.07 kB | ✓ |
| link.js gzip | 1.79 kB | 1.79 kB | ✓ |
| routerDirect.js | 423 B | 423 B | ✓ |
| routerDirect.js gzip | 290 B | 290 B | ✓ |
| withRouter.js | 435 B | 435 B | ✓ |
| withRouter.js gzip | 287 B | 287 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 865 B | 865 B | ✓ |
| _error.module.js | 5.82 kB | 5.82 kB | ✓ |
| _error.module.js gzip | 2.33 kB | 2.33 kB | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 3.78 kB | 3.78 kB | ✓ |
| link.module.js gzip | 1.7 kB | 1.7 kB | ✓ |
| routerDirect.module.js | 411 B | 411 B | ✓ |
| routerDirect.module.js gzip | 291 B | 291 B | ✓ |
| withRouter.module.js | 423 B | 423 B | ✓ |
| withRouter.module.js gzip | 288 B | 288 B | ✓ |
| Overall change | ✓ |
Fetched pages
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| link | 2.81 kB | 2.81 kB | ✓ |
| link gzip | 848 B | 843 B | -5 B |
| index | 2.76 kB | 2.76 kB | ✓ |
| index gzip | 838 B | 834 B | -4 B |
| withRouter | 2.82 kB | 2.82 kB | ✓ |
| withRouter gzip | 835 B | 831 B | -4 B |
| Overall change | ✓ |
Diffs
Diff for main-HASH.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[2],{
/***/ "/h46":
/***/ (function(module, exports, __webpack_require__) {
@@ -683,7 +683,7 @@ function markHydrateComplete() {
if (!_utils.SUPPORTS_PERFORMANCE_USER_TIMING) return;
performance.mark('afterHydrate'); // mark end of hydration
- performance.measure('Next.js-before-hydration', 'navigationStart', 'beforeRender');
+ performance.measure('Next.js-before-hydration', null, 'beforeRender');
performance.measure('Next.js-hydration', 'beforeRender', 'afterHydrate');
clearMarks();
}
@@ -705,7 +705,11 @@ function markRenderComplete() {
function clearMarks() {
performance.clearMarks();
- performance.clearMeasures();
+ /*
+ * TODO: uncomment the following line when we have a way to
+ * expose this to user code.
+ */
+ // performance.clearMeasures()
}
function AppContainer(_ref4) {Diff for commons.HASH.js
@@ -80,7 +80,7 @@ module.exports = __webpack_require__("WEpk").Object.getPrototypeOf;
*/
Object.defineProperty(exports,"__esModule",{value:!0});var d=void 0,e=void 0,g=void 0,m=void 0,n=void 0;exports.unstable_now=void 0;exports.unstable_forceFrameRate=void 0;
-if("undefined"===typeof window||"function"!==typeof MessageChannel){var p=null,q=null,r=function(){if(null!==p)try{var a=exports.unstable_now();p(!0,a);p=null}catch(b){throw setTimeout(r,0),b;}};exports.unstable_now=function(){return Date.now()};d=function(a){null!==p?setTimeout(d,0,a):(p=a,setTimeout(r,0))};e=function(a,b){q=setTimeout(a,b)};g=function(){clearTimeout(q)};m=function(){return!1};n=exports.unstable_forceFrameRate=function(){}}else{var t=window.performance,u=window.Date,v=window.setTimeout,
+if( false||"function"!==typeof MessageChannel){var p=null,q=null,r=function(){if(null!==p)try{var a=exports.unstable_now();p(!0,a);p=null}catch(b){throw setTimeout(r,0),b;}};exports.unstable_now=function(){return Date.now()};d=function(a){null!==p?setTimeout(d,0,a):(p=a,setTimeout(r,0))};e=function(a,b){q=setTimeout(a,b)};g=function(){clearTimeout(q)};m=function(){return!1};n=exports.unstable_forceFrameRate=function(){}}else{var t=window.performance,u=window.Date,v=window.setTimeout,
w=window.clearTimeout,x=window.requestAnimationFrame,y=window.cancelAnimationFrame;"undefined"!==typeof console&&("function"!==typeof x&&console.error("This browser doesn't support requestAnimationFrame. Make sure that you load a polyfill in older browsers. https://fb.me/react-polyfills"),"function"!==typeof y&&console.error("This browser doesn't support cancelAnimationFrame. Make sure that you load a polyfill in older browsers. https://fb.me/react-polyfills"));exports.unstable_now="object"===typeof t&&
"function"===typeof t.now?function(){return t.now()}:function(){return u.now()};var z=!1,A=null,B=-1,C=-1,D=33.33,E=-1,F=-1,G=0,H=!1;m=function(){return exports.unstable_now()>=G};n=function(){};exports.unstable_forceFrameRate=function(a){0>a||125<a?console.error("forceFrameRate takes a positive int between 0 and 125, forcing framerates higher than 125 fps is not unsupported"):0<a?(D=Math.floor(1E3/a),H=!0):(D=33.33,H=!1)};var J=function(){if(null!==A){var a=exports.unstable_now(),b=0<G-a;try{A(b,
a)||(A=null)}catch(c){throw I.postMessage(null),c;}}},K=new MessageChannel,I=K.port2;K.port1.onmessage=J;var L=function(a){if(null===A)F=E=-1,z=!1;else{z=!0;x(function(a){w(B);L(a)});var b=function(){G=exports.unstable_now()+D/2;J();B=v(b,3*D)};B=v(b,3*D);if(-1!==E&&.1<a-E){var c=a-E;!H&&-1!==F&&c<D&&F<D&&(D=c<F?F:c,8.33>D&&(D=8.33));F=c}E=a;G=a+D;I.postMessage(null)}};d=function(a){A=a;z||(z=!0,x(function(a){L(a)}))};e=function(a,b){C=v(function(){a(exports.unstable_now())},b)};g=function(){w(C);
@@ -539,10 +539,10 @@ module.exports = function (it) {
/***/ }),
/***/ "5T2Y":
-/***/ (function(module, exports) {
+/***/ (function(module, exports, __webpack_require__) {
// https://github.com/zloirock/core-js/issues/86#issuecomment-115759028
-var global = module.exports = typeof window != 'undefined' && window.Math == Math
+var global = module.exports = true && window.Math == Math
? window : typeof self != 'undefined' && self.Math == Math ? self
// eslint-disable-next-line no-new-func
: Function('return this')();
@@ -851,7 +851,7 @@ var toIObject = __webpack_require__("NsO/");
var gOPN = __webpack_require__("ar/p").f;
var toString = {}.toString;
-var windowNames = typeof window == 'object' && window && Object.getOwnPropertyNames
+var windowNames = true && window && Object.getOwnPropertyNames
? Object.getOwnPropertyNames(window) : [];
var getWindowNames = function (it) {
@@ -7415,7 +7415,7 @@ module.exports = Function.bind || function bind(that /* , ...args */) {
/***/ }),
/***/ "yLpj":
-/***/ (function(module, exports) {
+/***/ (function(module, exports, __webpack_require__) {
var g;
@@ -7429,7 +7429,7 @@ try {
g = g || new Function("return this")();
} catch (e) {
// This works if the window reference is available
- if (typeof window === "object") g = window;
+ if (true) g = window;
}
// g can still be undefined, but nothing to do about it...
@@ -7466,7 +7466,7 @@ var Ca={injectEventPluginOrder:function(a){if(ba)throw t(Error(101));ba=Array.pr
function Da(a,b){var c=a.stateNode;if(!c)return null;var d=sa(c);if(!d)return null;c=d[b];a:switch(b){case "onClick":case "onClickCapture":case "onDoubleClick":case "onDoubleClickCapture":case "onMouseDown":case "onMouseDownCapture":case "onMouseMove":case "onMouseMoveCapture":case "onMouseUp":case "onMouseUpCapture":(d=!d.disabled)||(a=a.type,d=!("button"===a||"input"===a||"select"===a||"textarea"===a));a=!d;break a;default:a=!1}if(a)return null;if(c&&"function"!==typeof c)throw t(Error(231),b,typeof c);
return c}var Ea=Math.random().toString(36).slice(2),Fa="__reactInternalInstance$"+Ea,Ga="__reactEventHandlers$"+Ea;function Ha(a){if(a[Fa])return a[Fa];for(;!a[Fa];)if(a.parentNode)a=a.parentNode;else return null;a=a[Fa];return 5===a.tag||6===a.tag?a:null}function Ia(a){a=a[Fa];return!a||5!==a.tag&&6!==a.tag?null:a}function Ja(a){if(5===a.tag||6===a.tag)return a.stateNode;throw t(Error(33));}function Ka(a){return a[Ga]||null}function La(a){do a=a.return;while(a&&5!==a.tag);return a?a:null}
function Ma(a,b,c){if(b=Da(a,c.dispatchConfig.phasedRegistrationNames[b]))c._dispatchListeners=xa(c._dispatchListeners,b),c._dispatchInstances=xa(c._dispatchInstances,a)}function Na(a){if(a&&a.dispatchConfig.phasedRegistrationNames){for(var b=a._targetInst,c=[];b;)c.push(b),b=La(b);for(b=c.length;0<b--;)Ma(c[b],"captured",a);for(b=0;b<c.length;b++)Ma(c[b],"bubbled",a)}}
-function Oa(a,b,c){a&&c&&c.dispatchConfig.registrationName&&(b=Da(a,c.dispatchConfig.registrationName))&&(c._dispatchListeners=xa(c._dispatchListeners,b),c._dispatchInstances=xa(c._dispatchInstances,a))}function Pa(a){a&&a.dispatchConfig.registrationName&&Oa(a._targetInst,null,a)}function Qa(a){ya(a,Na)}var Ra=!("undefined"===typeof window||"undefined"===typeof window.document||"undefined"===typeof window.document.createElement);
+function Oa(a,b,c){a&&c&&c.dispatchConfig.registrationName&&(b=Da(a,c.dispatchConfig.registrationName))&&(c._dispatchListeners=xa(c._dispatchListeners,b),c._dispatchInstances=xa(c._dispatchInstances,a))}function Pa(a){a&&a.dispatchConfig.registrationName&&Oa(a._targetInst,null,a)}function Qa(a){ya(a,Na)}var Ra=!( false||"undefined"===typeof window.document||"undefined"===typeof window.document.createElement);
function Sa(a,b){var c={};c[a.toLowerCase()]=b.toLowerCase();c["Webkit"+a]="webkit"+b;c["Moz"+a]="moz"+b;return c}var Ta={animationend:Sa("Animation","AnimationEnd"),animationiteration:Sa("Animation","AnimationIteration"),animationstart:Sa("Animation","AnimationStart"),transitionend:Sa("Transition","TransitionEnd")},Ua={},Va={};
Ra&&(Va=document.createElement("div").style,"AnimationEvent"in window||(delete Ta.animationend.animation,delete Ta.animationiteration.animation,delete Ta.animationstart.animation),"TransitionEvent"in window||delete Ta.transitionend.transition);function Wa(a){if(Ua[a])return Ua[a];if(!Ta[a])return a;var b=Ta[a],c;for(c in b)if(b.hasOwnProperty(c)&&c in Va)return Ua[a]=b[c];return a}
var Xa=Wa("animationend"),Ya=Wa("animationiteration"),Za=Wa("animationstart"),ab=Wa("transitionend"),bb="abort canplay canplaythrough durationchange emptied encrypted ended error loadeddata loadedmetadata loadstart pause play playing progress ratechange seeked seeking stalled suspend timeupdate volumechange waiting".split(" "),cb=null,db=null,eb=null;Diff for main-HASH.module.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[2],{
/***/ "+oT+":
/***/ (function(module, exports, __webpack_require__) {
@@ -565,7 +565,7 @@ function markHydrateComplete() {
if (!_utils.SUPPORTS_PERFORMANCE_USER_TIMING) return;
performance.mark('afterHydrate'); // mark end of hydration
- performance.measure('Next.js-before-hydration', 'navigationStart', 'beforeRender');
+ performance.measure('Next.js-before-hydration', null, 'beforeRender');
performance.measure('Next.js-hydration', 'beforeRender', 'afterHydrate');
clearMarks();
}
@@ -587,7 +587,11 @@ function markRenderComplete() {
function clearMarks() {
performance.clearMarks();
- performance.clearMeasures();
+ /*
+ * TODO: uncomment the following line when we have a way to
+ * expose this to user code.
+ */
+ // performance.clearMeasures()
}
function AppContainer(_ref4) {Diff for commons.HASH.module.js
@@ -14,7 +14,7 @@
*/
Object.defineProperty(exports,"__esModule",{value:!0});var d=void 0,e=void 0,g=void 0,m=void 0,n=void 0;exports.unstable_now=void 0;exports.unstable_forceFrameRate=void 0;
-if("undefined"===typeof window||"function"!==typeof MessageChannel){var p=null,q=null,r=function(){if(null!==p)try{var a=exports.unstable_now();p(!0,a);p=null}catch(b){throw setTimeout(r,0),b;}};exports.unstable_now=function(){return Date.now()};d=function(a){null!==p?setTimeout(d,0,a):(p=a,setTimeout(r,0))};e=function(a,b){q=setTimeout(a,b)};g=function(){clearTimeout(q)};m=function(){return!1};n=exports.unstable_forceFrameRate=function(){}}else{var t=window.performance,u=window.Date,v=window.setTimeout,
+if( false||"function"!==typeof MessageChannel){var p=null,q=null,r=function(){if(null!==p)try{var a=exports.unstable_now();p(!0,a);p=null}catch(b){throw setTimeout(r,0),b;}};exports.unstable_now=function(){return Date.now()};d=function(a){null!==p?setTimeout(d,0,a):(p=a,setTimeout(r,0))};e=function(a,b){q=setTimeout(a,b)};g=function(){clearTimeout(q)};m=function(){return!1};n=exports.unstable_forceFrameRate=function(){}}else{var t=window.performance,u=window.Date,v=window.setTimeout,
w=window.clearTimeout,x=window.requestAnimationFrame,y=window.cancelAnimationFrame;"undefined"!==typeof console&&("function"!==typeof x&&console.error("This browser doesn't support requestAnimationFrame. Make sure that you load a polyfill in older browsers. https://fb.me/react-polyfills"),"function"!==typeof y&&console.error("This browser doesn't support cancelAnimationFrame. Make sure that you load a polyfill in older browsers. https://fb.me/react-polyfills"));exports.unstable_now="object"===typeof t&&
"function"===typeof t.now?function(){return t.now()}:function(){return u.now()};var z=!1,A=null,B=-1,C=-1,D=33.33,E=-1,F=-1,G=0,H=!1;m=function(){return exports.unstable_now()>=G};n=function(){};exports.unstable_forceFrameRate=function(a){0>a||125<a?console.error("forceFrameRate takes a positive int between 0 and 125, forcing framerates higher than 125 fps is not unsupported"):0<a?(D=Math.floor(1E3/a),H=!0):(D=33.33,H=!1)};var J=function(){if(null!==A){var a=exports.unstable_now(),b=0<G-a;try{A(b,
a)||(A=null)}catch(c){throw I.postMessage(null),c;}}},K=new MessageChannel,I=K.port2;K.port1.onmessage=J;var L=function(a){if(null===A)F=E=-1,z=!1;else{z=!0;x(function(a){w(B);L(a)});var b=function(){G=exports.unstable_now()+D/2;J();B=v(b,3*D)};B=v(b,3*D);if(-1!==E&&.1<a-E){var c=a-E;!H&&-1!==F&&c<D&&F<D&&(D=c<F?F:c,8.33>D&&(D=8.33));F=c}E=a;G=a+D;I.postMessage(null)}};d=function(a){A=a;z||(z=!0,x(function(a){L(a)}))};e=function(a,b){C=v(function(){a(exports.unstable_now())},b)};g=function(){w(C);
@@ -411,10 +411,10 @@ module.exports = function (it) {
/***/ }),
/***/ "5T2Y":
-/***/ (function(module, exports) {
+/***/ (function(module, exports, __webpack_require__) {
// https://github.com/zloirock/core-js/issues/86#issuecomment-115759028
-var global = module.exports = typeof window != 'undefined' && window.Math == Math
+var global = module.exports = true && window.Math == Math
? window : typeof self != 'undefined' && self.Math == Math ? self
// eslint-disable-next-line no-new-func
: Function('return this')();
@@ -5509,7 +5509,7 @@ module.exports = Object.keys || function keys(O) {
/***/ }),
/***/ "yLpj":
-/***/ (function(module, exports) {
+/***/ (function(module, exports, __webpack_require__) {
var g;
@@ -5523,7 +5523,7 @@ try {
g = g || new Function("return this")();
} catch (e) {
// This works if the window reference is available
- if (typeof window === "object") g = window;
+ if (true) g = window;
}
// g can still be undefined, but nothing to do about it...
@@ -5560,7 +5560,7 @@ var Ca={injectEventPluginOrder:function(a){if(ba)throw t(Error(101));ba=Array.pr
function Da(a,b){var c=a.stateNode;if(!c)return null;var d=sa(c);if(!d)return null;c=d[b];a:switch(b){case "onClick":case "onClickCapture":case "onDoubleClick":case "onDoubleClickCapture":case "onMouseDown":case "onMouseDownCapture":case "onMouseMove":case "onMouseMoveCapture":case "onMouseUp":case "onMouseUpCapture":(d=!d.disabled)||(a=a.type,d=!("button"===a||"input"===a||"select"===a||"textarea"===a));a=!d;break a;default:a=!1}if(a)return null;if(c&&"function"!==typeof c)throw t(Error(231),b,typeof c);
return c}var Ea=Math.random().toString(36).slice(2),Fa="__reactInternalInstance$"+Ea,Ga="__reactEventHandlers$"+Ea;function Ha(a){if(a[Fa])return a[Fa];for(;!a[Fa];)if(a.parentNode)a=a.parentNode;else return null;a=a[Fa];return 5===a.tag||6===a.tag?a:null}function Ia(a){a=a[Fa];return!a||5!==a.tag&&6!==a.tag?null:a}function Ja(a){if(5===a.tag||6===a.tag)return a.stateNode;throw t(Error(33));}function Ka(a){return a[Ga]||null}function La(a){do a=a.return;while(a&&5!==a.tag);return a?a:null}
function Ma(a,b,c){if(b=Da(a,c.dispatchConfig.phasedRegistrationNames[b]))c._dispatchListeners=xa(c._dispatchListeners,b),c._dispatchInstances=xa(c._dispatchInstances,a)}function Na(a){if(a&&a.dispatchConfig.phasedRegistrationNames){for(var b=a._targetInst,c=[];b;)c.push(b),b=La(b);for(b=c.length;0<b--;)Ma(c[b],"captured",a);for(b=0;b<c.length;b++)Ma(c[b],"bubbled",a)}}
-function Oa(a,b,c){a&&c&&c.dispatchConfig.registrationName&&(b=Da(a,c.dispatchConfig.registrationName))&&(c._dispatchListeners=xa(c._dispatchListeners,b),c._dispatchInstances=xa(c._dispatchInstances,a))}function Pa(a){a&&a.dispatchConfig.registrationName&&Oa(a._targetInst,null,a)}function Qa(a){ya(a,Na)}var Ra=!("undefined"===typeof window||"undefined"===typeof window.document||"undefined"===typeof window.document.createElement);
+function Oa(a,b,c){a&&c&&c.dispatchConfig.registrationName&&(b=Da(a,c.dispatchConfig.registrationName))&&(c._dispatchListeners=xa(c._dispatchListeners,b),c._dispatchInstances=xa(c._dispatchInstances,a))}function Pa(a){a&&a.dispatchConfig.registrationName&&Oa(a._targetInst,null,a)}function Qa(a){ya(a,Na)}var Ra=!( false||"undefined"===typeof window.document||"undefined"===typeof window.document.createElement);
function Sa(a,b){var c={};c[a.toLowerCase()]=b.toLowerCase();c["Webkit"+a]="webkit"+b;c["Moz"+a]="moz"+b;return c}var Ta={animationend:Sa("Animation","AnimationEnd"),animationiteration:Sa("Animation","AnimationIteration"),animationstart:Sa("Animation","AnimationStart"),transitionend:Sa("Transition","TransitionEnd")},Ua={},Va={};
Ra&&(Va=document.createElement("div").style,"AnimationEvent"in window||(delete Ta.animationend.animation,delete Ta.animationiteration.animation,delete Ta.animationstart.animation),"TransitionEvent"in window||delete Ta.transitionend.transition);function Wa(a){if(Ua[a])return Ua[a];if(!Ta[a])return a;var b=Ta[a],c;for(c in b)if(b.hasOwnProperty(c)&&c in Va)return Ua[a]=b[c];return a}
var Xa=Wa("animationend"),Ya=Wa("animationiteration"),Za=Wa("animationstart"),ab=Wa("transitionend"),bb="abort canplay canplaythrough durationchange emptied encrypted ended error loadeddata loadedmetadata loadstart pause play playing progress ratechange seeked seeking stalled suspend timeupdate volumechange waiting".split(" "),cb=null,db=null,eb=null;Diff for _app.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[2],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
/***/ "B5Ud":
/***/ (function(module, exports, __webpack_require__) {Diff for _error.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
/***/ "+iuc":
/***/ (function(module, exports, __webpack_require__) {
@@ -229,7 +229,7 @@ _Object$defineProperty(exports, "__esModule", {
var react_1 = __webpack_require__("q1tI");
-var isServer = false;
+var isServer = "object" === 'undefined';
exports["default"] = function () {
var mountedInstances = new _Set();Diff for index.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
/***/ "RNiq":
/***/ (function(module, __webpack_exports__, __webpack_require__) {Diff for link.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
/***/ "/h46":
/***/ (function(module, exports, __webpack_require__) {
@@ -157,7 +157,7 @@ function formatUrl(url) {
var observer;
var listeners = new _map["default"]();
-var IntersectionObserver = true ? window.IntersectionObserver : undefined;
+var IntersectionObserver = true ? window.IntersectionObserver : undefined;
function getObserver() {
// Return shared instance of IntersectionObserver if already created
@@ -298,7 +298,7 @@ function (_react$Component) {
}, {
key: "prefetch",
value: function prefetch() {
- if (!this.p || false) return; // Prefetch the JSON page if asked (only in the client)
+ if (!this.p || "object" === 'undefined') return; // Prefetch the JSON page if asked (only in the client)
var pathname = window.location.pathname;Diff for routerDirect.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
/***/ "LtRI":
/***/ (function(module, exports, __webpack_require__) {Diff for withRouter.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
/***/ "0Hlz":
/***/ (function(module, __webpack_exports__, __webpack_require__) {Diff for _app.module.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[2],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
/***/ "+oT+":
/***/ (function(module, exports, __webpack_require__) {Diff for _error.module.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
/***/ "+iuc":
/***/ (function(module, exports, __webpack_require__) {
@@ -171,7 +171,7 @@ _Object$defineProperty(exports, "__esModule", {
const react_1 = __webpack_require__("q1tI");
-const isServer = false;
+const isServer = "object" === 'undefined';
exports.default = () => {
const mountedInstances = new _Set();Diff for index.module.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
/***/ "RNiq":
/***/ (function(module, __webpack_exports__, __webpack_require__) {Diff for link.module.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
/***/ "/h46":
/***/ (function(module, exports, __webpack_require__) {
@@ -145,7 +145,7 @@ function formatUrl(url) {
let observer;
const listeners = new _map.default();
-const IntersectionObserver = true ? window.IntersectionObserver : undefined;
+const IntersectionObserver = true ? window.IntersectionObserver : undefined;
function getObserver() {
// Return shared instance of IntersectionObserver if already created
@@ -277,7 +277,7 @@ class Link extends _react.Component {
prefetch() {
- if (!this.p || false) return; // Prefetch the JSON page if asked (only in the client)
+ if (!this.p || "object" === 'undefined') return; // Prefetch the JSON page if asked (only in the client)
const {
pathnameDiff for routerDirect.module.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
/***/ "LtRI":
/***/ (function(module, exports, __webpack_require__) {Diff for withRouter.module.js
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
/***/ "0Hlz":
/***/ (function(module, __webpack_exports__, __webpack_require__) {Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| buildDuration | 22.6s | 22.2s | -417ms |
| nodeModulesSize | 41.3 MB | 41.5 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| main-HASH.js | 13.8 kB | 13.8 kB | -41 B |
| main-HASH.js gzip | 4.87 kB | 4.85 kB | -16 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.js | 194 kB | 194 kB | -135 B |
| commons.HASH.js gzip | 63.1 kB | 63.1 kB | -26 B |
| Overall change | -176 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| main-HASH.module.js | 11.4 kB | 11.4 kB | -41 B |
| main-HASH.module.js gzip | 4.31 kB | 4.29 kB | -16 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.module.js | 176 kB | 175 kB | -110 B |
| commons.HASH.module.js gzip | 57.2 kB | 57.1 kB | -22 B |
| Overall change | -151 B |
Client Pages
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 905 B | 905 B | ✓ |
| _error.js | 8.02 kB | 8.02 kB | ✓ |
| _error.js gzip | 3.12 kB | 3.12 kB | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 4.07 kB | 4.07 kB | ✓ |
| link.js gzip | 1.79 kB | 1.79 kB | ✓ |
| routerDirect.js | 423 B | 423 B | ✓ |
| routerDirect.js gzip | 290 B | 290 B | ✓ |
| withRouter.js | 435 B | 435 B | ✓ |
| withRouter.js gzip | 287 B | 287 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 865 B | 865 B | ✓ |
| _error.module.js | 5.82 kB | 5.82 kB | ✓ |
| _error.module.js gzip | 2.33 kB | 2.33 kB | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 3.78 kB | 3.78 kB | ✓ |
| link.module.js gzip | 1.7 kB | 1.7 kB | ✓ |
| routerDirect.module.js | 411 B | 411 B | ✓ |
| routerDirect.module.js gzip | 291 B | 291 B | ✓ |
| withRouter.module.js | 423 B | 423 B | ✓ |
| withRouter.module.js gzip | 288 B | 288 B | ✓ |
| Overall change | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _error.js | 247 kB | 247 kB | |
| _error.js gzip | 66.2 kB | 66.2 kB | -13 B |
| index.js | 247 kB | 247 kB | |
| index.js gzip | 66.5 kB | 66.5 kB | -11 B |
| link.js | 255 kB | 255 kB | |
| link.js gzip | 68.7 kB | 68.7 kB | -1 B |
| routerDirect.js | 248 kB | 248 kB | |
| routerDirect.js gzip | 66.4 kB | 66.4 kB | -14 B |
| withRouter.js | 248 kB | 248 kB | |
| withRouter.js gzip | 66.5 kB | 66.5 kB | -10 B |
| Overall change |
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| buildDuration | 23.7s | 22.9s | -834ms |
| nodeModulesSize | 41.3 MB | 41.3 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| main-HASH.js | 13.8 kB | 13.8 kB | -28 B |
| main-HASH.js gzip | 4.87 kB | 4.86 kB | -9 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.js | 194 kB | 194 kB | ✓ |
| commons.HASH.js gzip | 63.1 kB | 63.1 kB | ✓ |
| Overall change | -28 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| main-HASH.module.js | 11.4 kB | 11.4 kB | -28 B |
| main-HASH.module.js gzip | 4.31 kB | 4.3 kB | -8 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.module.js | 176 kB | 176 kB | ✓ |
| commons.HASH.module.js gzip | 57.2 kB | 57.2 kB | ✓ |
| Overall change | -28 B |
Client Pages
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 905 B | 905 B | ✓ |
| _error.js | 8.02 kB | 8.02 kB | ✓ |
| _error.js gzip | 3.12 kB | 3.12 kB | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 4.07 kB | 4.07 kB | ✓ |
| link.js gzip | 1.79 kB | 1.79 kB | ✓ |
| routerDirect.js | 423 B | 423 B | ✓ |
| routerDirect.js gzip | 290 B | 290 B | ✓ |
| withRouter.js | 435 B | 435 B | ✓ |
| withRouter.js gzip | 287 B | 287 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 865 B | 865 B | ✓ |
| _error.module.js | 5.82 kB | 5.82 kB | ✓ |
| _error.module.js gzip | 2.33 kB | 2.33 kB | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 3.78 kB | 3.78 kB | ✓ |
| link.module.js gzip | 1.7 kB | 1.7 kB | ✓ |
| routerDirect.module.js | 411 B | 411 B | ✓ |
| routerDirect.module.js gzip | 291 B | 291 B | ✓ |
| withRouter.module.js | 423 B | 423 B | ✓ |
| withRouter.module.js gzip | 288 B | 288 B | ✓ |
| Overall change | ✓ |
Fetched pages
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| link | 2.81 kB | 2.81 kB | ✓ |
| link gzip | 846 B | 846 B | ✓ |
| index | 2.76 kB | 2.76 kB | ✓ |
| index gzip | 837 B | 840 B | |
| withRouter | 2.82 kB | 2.82 kB | ✓ |
| withRouter gzip | 830 B | 834 B | |
| Overall change | ✓ |
Diffs
Diff for main-HASH.js
@@ -705,7 +705,11 @@ function markRenderComplete() {
function clearMarks() {
performance.clearMarks();
- performance.clearMeasures();
+ /*
+ * TODO: uncomment the following line when we have a way to
+ * expose this to user code.
+ */
+ // performance.clearMeasures()
}
function AppContainer(_ref4) {Diff for main-HASH.module.js
@@ -587,7 +587,11 @@ function markRenderComplete() {
function clearMarks() {
performance.clearMarks();
- performance.clearMeasures();
+ /*
+ * TODO: uncomment the following line when we have a way to
+ * expose this to user code.
+ */
+ // performance.clearMeasures()
}
function AppContainer(_ref4) {Serverless Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| buildDuration | 24.9s | 24.5s | -362ms |
| nodeModulesSize | 41.3 MB | 41.3 MB |
Client Bundles (main, webpack, commons) Overall decrease ✓
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| main-HASH.js | 13.8 kB | 13.8 kB | -28 B |
| main-HASH.js gzip | 4.87 kB | 4.86 kB | -9 B |
| webpack-HASH.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.js | 194 kB | 194 kB | ✓ |
| commons.HASH.js gzip | 63.1 kB | 63.1 kB | ✓ |
| Overall change | -28 B |
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| main-HASH.module.js | 11.4 kB | 11.4 kB | -28 B |
| main-HASH.module.js gzip | 4.31 kB | 4.3 kB | -8 B |
| webpack-HASH.module.js | 1.53 kB | 1.53 kB | ✓ |
| webpack-HASH.module.js gzip | 746 B | 746 B | ✓ |
| commons.HASH.module.js | 176 kB | 176 kB | ✓ |
| commons.HASH.module.js gzip | 57.2 kB | 57.2 kB | ✓ |
| Overall change | -28 B |
Client Pages
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _app.js | 1.9 kB | 1.9 kB | ✓ |
| _app.js gzip | 905 B | 905 B | ✓ |
| _error.js | 8.02 kB | 8.02 kB | ✓ |
| _error.js gzip | 3.12 kB | 3.12 kB | ✓ |
| index.js | 343 B | 343 B | ✓ |
| index.js gzip | 237 B | 237 B | ✓ |
| link.js | 4.07 kB | 4.07 kB | ✓ |
| link.js gzip | 1.79 kB | 1.79 kB | ✓ |
| routerDirect.js | 423 B | 423 B | ✓ |
| routerDirect.js gzip | 290 B | 290 B | ✓ |
| withRouter.js | 435 B | 435 B | ✓ |
| withRouter.js gzip | 286 B | 286 B | ✓ |
| Overall change | ✓ |
Client Pages Modern
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _app.module.js | 1.79 kB | 1.79 kB | ✓ |
| _app.module.js gzip | 865 B | 865 B | ✓ |
| _error.module.js | 5.82 kB | 5.82 kB | ✓ |
| _error.module.js gzip | 2.33 kB | 2.33 kB | ✓ |
| index.module.js | 319 B | 319 B | ✓ |
| index.module.js gzip | 238 B | 238 B | ✓ |
| link.module.js | 3.78 kB | 3.78 kB | ✓ |
| link.module.js gzip | 1.7 kB | 1.7 kB | ✓ |
| routerDirect.module.js | 411 B | 411 B | ✓ |
| routerDirect.module.js gzip | 291 B | 291 B | ✓ |
| withRouter.module.js | 423 B | 423 B | ✓ |
| withRouter.module.js gzip | 288 B | 288 B | ✓ |
| Overall change | ✓ |
Serverless bundles
| zeit/next.js canary | azukaru/next.js rever-clear-measures | Change | |
|---|---|---|---|
| _error.js | 247 kB | 247 kB | ✓ |
| _error.js gzip | 66.2 kB | 66.2 kB | -5 B |
| index.js | 247 kB | 247 kB | ✓ |
| index.js gzip | 66.5 kB | 66.5 kB | -4 B |
| link.js | 255 kB | 255 kB | ✓ |
| link.js gzip | 68.7 kB | 68.7 kB | -5 B |
| routerDirect.js | 248 kB | 248 kB | ✓ |
| routerDirect.js gzip | 66.4 kB | 66.4 kB | -4 B |
| withRouter.js | 248 kB | 248 kB | ✓ |
| withRouter.js gzip | 66.5 kB | 66.5 kB | -3 B |
| Overall change | ✓ |
timneutkens
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearMeasureintroduced in Adds user timing marks and measures for hydration/render #8069, as this makes it impossible for users to send these measures to their analytics.