New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for dynamic routing/webpack HMR bug #8061

Merged

ijjk merged 7 commits into vercel:canary from ijjk:test-dynamic-routing

Aug 1, 2019

Member

ijjk commented Jul 22, 2019 •

edited

Loading

Adds test case for dynamic routes failing to HMR when they contain a special webpack value e.g. [name].

Fixes: #7775
Relies on: webpack/webpack#9454

ijjk added 2 commits

July 22, 2019 12:52


          Add failing test for dynamic routing/webpack HMR bug

3224c99


          Remove un-used args from onDemandEntryHandler

b651912

ijjk requested review from lfades, Timer and timneutkens as code owners

July 22, 2019 17:56

Contributor

github-actions bot commented Jul 22, 2019

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js test-dynamic-routing	Change
Build Duration	13.9s	13.7s	-194ms
`node_modules` Size	45.5 MB	45.5 MB	-137 B
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	343 B	343 B	✓
Client `pages/index` gzip Size	246 B	246 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	300 B	300 B	✓
Client `main` Size	19.8 kB	19.8 kB	✓
Client `main` gzip Size	6.78 kB	6.78 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	738 kB	738 kB	✓

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js test-dynamic-routing	Change
Build Duration	15s	14.9s	-105ms
`node_modules` Size	45.5 MB	45.5 MB	-137 B
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	343 B	343 B	✓
Client `pages/index` gzip Size	246 B	246 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	19.8 kB	19.8 kB	✓
Client `main` gzip Size	6.78 kB	6.78 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	338 kB	338 kB	✓
Serverless `pages/link` gzip Size	86.9 kB	86.9 kB	✓
Serverless `pages/index` Size	329 kB	329 kB	✓
Serverless `pages/index` gzip Size	84.4 kB	84.4 kB	-1 B
Serverless `pages/_error` Size	329 kB	329 kB	✓
Serverless `pages/_error` gzip Size	84.2 kB	84.2 kB	✓
Serverless `pages/routerDirect` Size	330 kB	330 kB	✓
Serverless `pages/routerDirect` gzip Size	84.4 kB	84.4 kB	✓
Serverless `pages/withRouter` Size	330 kB	330 kB	✓
Serverless `pages/withRouter` gzip Size	84.4 kB	84.4 kB	✓
Build Dir Size	2.26 MB	2.26 MB	✓

Timer added this to the 9.0.3 milestone

ijjk mentioned this pull request

Escape path variables in replaced values for TemplatedPathPlugin webpack/webpack#9454

Merged

Contributor

kodiakhq bot commented Jul 25, 2019

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

4 similar comments

Contributor

kodiakhq bot commented Jul 25, 2019

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

Contributor

kodiakhq bot commented Jul 25, 2019

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

Contributor

kodiakhq bot commented Jul 25, 2019

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

Contributor

kodiakhq bot commented Jul 25, 2019

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

Timer mentioned this pull request

Bot issuing duplicate comments chdsbd/kodiak#84

Closed

webpack-bot mentioned this pull request

Document webpack change: Escape path variables in replaced values for TemplatedPathPlugin webpack/webpack.js.org#3219

Closed

Timer assigned ijjk


          Merge remote-tracking branch 'upstream/canary' into test-dynamic-routing

894abe4

Timer modified the milestones: 9.0.3, 9.0.4

Timer force-pushed the canary branch from a31eb1b to dc9e270 Compare

July 31, 2019 20:14

ijjk added 3 commits

August 1, 2019 10:42


          Merge remote-tracking branch 'upstream/canary' into test-dynamic-routing

35ecd2c


          update to latest webpack with escaping

d8149ff


          Merge remote-tracking branch 'upstream/canary' into test-dynamic-routing

64396a0

Contributor

github-actions bot commented Aug 1, 2019

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js test-dynamic-routing	Change
Build Duration	14.2s	13.8s	-364ms
`node_modules` Size	45.9 MB	45.9 MB	⚠️ +5.7 kB
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.22 kB	8.22 kB	✓
Client `_error` gzip Size	3.16 kB	3.16 kB	✓
Client `pages/index` Size	343 B	343 B	✓
Client `pages/index` gzip Size	246 B	246 B	✓
Client `pages/link` Size	4.08 kB	4.08 kB	✓
Client `pages/link` gzip Size	1.8 kB	1.8 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	15.4 kB	15.4 kB	✓
Client `main` gzip Size	5.35 kB	5.35 kB	✓
Client `commons` Size	188 kB	188 kB	✓
Client `commons` gzip Size	61.1 kB	61.1 kB	✓
Client `webpack` Size	1.49 kB	1.53 kB	⚠️ +43 B
Client `webpack` gzip Size	770 B	778 B	⚠️ +8 B
Base Rendered Size	1.35 kB	1.35 kB	✓
Build Dir Size	702 kB	702 kB	⚠️ +86 B

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js test-dynamic-routing	Change
Build Duration	15.6s	15.1s	-456ms
`node_modules` Size	45.9 MB	45.9 MB	⚠️ +5.7 kB
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.22 kB	8.22 kB	✓
Client `_error` gzip Size	3.16 kB	3.16 kB	✓
Client `pages/index` Size	343 B	343 B	✓
Client `pages/index` gzip Size	246 B	246 B	✓
Client `pages/link` Size	4.08 kB	4.08 kB	✓
Client `pages/link` gzip Size	1.8 kB	1.8 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	15.4 kB	15.4 kB	✓
Client `main` gzip Size	5.35 kB	5.35 kB	✓
Client `commons` Size	188 kB	188 kB	✓
Client `commons` gzip Size	61.1 kB	61.1 kB	✓
Client `webpack` Size	1.49 kB	1.53 kB	⚠️ +43 B
Client `webpack` gzip Size	770 B	778 B	⚠️ +8 B
Serverless `pages/link` Size	252 kB	252 kB	✓
Serverless `pages/link` gzip Size	67.9 kB	67.9 kB	-2 B
Serverless `pages/index` Size	244 kB	244 kB	✓
Serverless `pages/index` gzip Size	65.8 kB	65.8 kB	-1 B
Serverless `pages/_error` Size	244 kB	244 kB	✓
Serverless `pages/_error` gzip Size	65.5 kB	65.5 kB	-1 B
Serverless `pages/routerDirect` Size	245 kB	245 kB	✓
Serverless `pages/routerDirect` gzip Size	65.7 kB	65.7 kB	-1 B
Serverless `pages/withRouter` Size	245 kB	245 kB	✓
Serverless `pages/withRouter` gzip Size	65.9 kB	65.8 kB	-2 B
Build Dir Size	1.89 MB	1.89 MB	⚠️ +86 B


          Merge remote-tracking branch 'upstream/canary' into test-dynamic-routing

ce3f355

Contributor

github-actions bot commented Aug 1, 2019

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js test-dynamic-routing	Change
Build Duration	13.6s	13.7s	⚠️ +128ms
`node_modules` Size	45.9 MB	45.9 MB	⚠️ +5.99 kB
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	-1 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	-1 B
Client `_error` Size	8.22 kB	8.22 kB	✓
Client `_error` gzip Size	3.16 kB	3.16 kB	✓
Client `pages/index` Size	343 B	343 B	✓
Client `pages/index` gzip Size	246 B	246 B	✓
Client `pages/link` Size	4.08 kB	4.08 kB	✓
Client `pages/link` gzip Size	1.8 kB	1.8 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	300 B	-1 B
Client `main` Size	15.4 kB	15.4 kB	✓
Client `main` gzip Size	5.35 kB	5.35 kB	✓
Client `commons` Size	188 kB	188 kB	✓
Client `commons` gzip Size	61.1 kB	61.1 kB	✓
Client `webpack` Size	1.49 kB	1.53 kB	⚠️ +43 B
Client `webpack` gzip Size	770 B	778 B	⚠️ +8 B
Base Rendered Size	1.35 kB	1.35 kB	✓
Build Dir Size	702 kB	702 kB	⚠️ +86 B

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js test-dynamic-routing	Change
Build Duration	14.7s	14.5s	-210ms
`node_modules` Size	45.9 MB	45.9 MB	⚠️ +5.99 kB
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.22 kB	8.22 kB	✓
Client `_error` gzip Size	3.16 kB	3.16 kB	✓
Client `pages/index` Size	343 B	343 B	✓
Client `pages/index` gzip Size	246 B	246 B	✓
Client `pages/link` Size	4.08 kB	4.08 kB	✓
Client `pages/link` gzip Size	1.8 kB	1.8 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	15.4 kB	15.4 kB	✓
Client `main` gzip Size	5.35 kB	5.35 kB	✓
Client `commons` Size	188 kB	188 kB	✓
Client `commons` gzip Size	61.1 kB	61.1 kB	✓
Client `webpack` Size	1.49 kB	1.53 kB	⚠️ +43 B
Client `webpack` gzip Size	770 B	778 B	⚠️ +8 B
Serverless `pages/link` Size	252 kB	252 kB	✓
Serverless `pages/link` gzip Size	67.9 kB	67.9 kB	✓
Serverless `pages/index` Size	244 kB	244 kB	✓
Serverless `pages/index` gzip Size	65.8 kB	65.8 kB	⚠️ +1 B
Serverless `pages/_error` Size	244 kB	244 kB	✓
Serverless `pages/_error` gzip Size	65.5 kB	65.5 kB	-1 B
Serverless `pages/routerDirect` Size	245 kB	245 kB	✓
Serverless `pages/routerDirect` gzip Size	65.7 kB	65.7 kB	-1 B
Serverless `pages/withRouter` Size	245 kB	245 kB	✓
Serverless `pages/withRouter` gzip Size	65.9 kB	65.8 kB	-1 B
Build Dir Size	1.89 MB	1.89 MB	⚠️ +86 B

Contributor

github-actions bot commented Aug 1, 2019

Stats from current PR

Click to expand stats

	zeit/next.js canary	ijjk/next.js test-dynamic-routing	Change
Build Duration	12.7s	12.8s	⚠️ +76ms
`node_modules` Size	45.9 MB	45.9 MB	⚠️ +5.99 kB
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.22 kB	8.22 kB	✓
Client `_error` gzip Size	3.16 kB	3.16 kB	✓
Client `pages/index` Size	343 B	343 B	✓
Client `pages/index` gzip Size	246 B	246 B	✓
Client `pages/link` Size	4.08 kB	4.08 kB	✓
Client `pages/link` gzip Size	1.8 kB	1.8 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	15.4 kB	15.4 kB	✓
Client `main` gzip Size	5.35 kB	5.35 kB	✓
Client `commons` Size	188 kB	188 kB	✓
Client `commons` gzip Size	61.1 kB	61.1 kB	✓
Client `webpack` Size	1.49 kB	1.53 kB	⚠️ +43 B
Client `webpack` gzip Size	770 B	778 B	⚠️ +8 B
Base Rendered Size	1.35 kB	1.35 kB	✓
Build Dir Size	702 kB	702 kB	⚠️ +86 B

Click to expand serverless stats

	zeit/next.js canary	ijjk/next.js test-dynamic-routing	Change
Build Duration	14.1s	14s	-134ms
`node_modules` Size	45.9 MB	45.9 MB	⚠️ +5.99 kB
Total Bundle (main, webpack, commons) Size	206 kB	206 kB	✓
Total Bundle (main, webpack, commons) gzip Size	67.8 kB	67.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.22 kB	8.22 kB	✓
Client `_error` gzip Size	3.16 kB	3.16 kB	✓
Client `pages/index` Size	343 B	343 B	✓
Client `pages/index` gzip Size	246 B	246 B	✓
Client `pages/link` Size	4.08 kB	4.08 kB	✓
Client `pages/link` gzip Size	1.8 kB	1.8 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	15.4 kB	15.4 kB	✓
Client `main` gzip Size	5.35 kB	5.35 kB	✓
Client `commons` Size	188 kB	188 kB	✓
Client `commons` gzip Size	61.1 kB	61.1 kB	✓
Client `webpack` Size	1.49 kB	1.53 kB	⚠️ +43 B
Client `webpack` gzip Size	770 B	778 B	⚠️ +8 B
Serverless `pages/link` Size	252 kB	252 kB	✓
Serverless `pages/link` gzip Size	67.9 kB	67.9 kB	-1 B
Serverless `pages/index` Size	244 kB	244 kB	✓
Serverless `pages/index` gzip Size	65.8 kB	65.8 kB	✓
Serverless `pages/_error` Size	244 kB	244 kB	✓
Serverless `pages/_error` gzip Size	65.5 kB	65.5 kB	✓
Serverless `pages/routerDirect` Size	245 kB	245 kB	✓
Serverless `pages/routerDirect` gzip Size	65.7 kB	65.7 kB	⚠️ +1 B
Serverless `pages/withRouter` Size	245 kB	245 kB	✓
Serverless `pages/withRouter` gzip Size	65.9 kB	65.8 kB	-1 B
Build Dir Size	1.89 MB	1.89 MB	⚠️ +86 B

Timer approved these changes

View reviewed changes

ijjk merged commit e7d96f7 into vercel:canary

ijjk deleted the test-dynamic-routing branch

August 1, 2019 16:17

vercel locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.