Implemented example for rbx and bulma-pro #7728

Restoration · 2019-07-02T09:28:33Z

Added example with rbx and bulma-pro package

github-actions · 2019-07-02T09:33:56Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	Restoration/next.js with-rbx-bulma-pro	Change
Build Duration	15.1s	14.8s	-296ms
`node_modules` Size	45.2 MB	45.2 MB	⚠️ +28 B
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70.1 kB	70.1 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.44 kB	8.44 kB	✓
Client `_error` gzip Size	3.23 kB	3.23 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.74 kB	4.74 kB	✓
Client `pages/link` gzip Size	2.02 kB	2.02 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.14 kB	9.14 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	756 kB	756 kB	✓

Click to expand serverless stats

	zeit/next.js canary	Restoration/next.js with-rbx-bulma-pro	Change
Build Duration	17.5s	17.1s	-406ms
`node_modules` Size	45.2 MB	45.2 MB	⚠️ +28 B
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70.1 kB	70.1 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.44 kB	8.44 kB	✓
Client `_error` gzip Size	3.23 kB	3.23 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.74 kB	4.74 kB	✓
Client `pages/link` gzip Size	2.02 kB	2.02 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.14 kB	9.14 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	Error getting size	Error getting size	✓
Serverless `pages/link` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	329 kB	329 kB	✓
Serverless `pages/_error` gzip Size	84.2 kB	84.2 kB	✓
Serverless `pages/routerDirect` Size	Error getting size	Error getting size	✓
Serverless `pages/routerDirect` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/withRouter` Size	Error getting size	Error getting size	✓
Serverless `pages/withRouter` gzip Size	Error getting size	Error getting size	✓
Build Dir Size	1.06 MB	1.06 MB	✓

Changed double quote to single quote

github-actions · 2019-07-02T10:08:28Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	Restoration/next.js with-rbx-bulma-pro	Change
Build Duration	14.5s	14.1s	-378ms
`node_modules` Size	45.2 MB	45.2 MB	⚠️ +28 B
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70.1 kB	70.1 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.44 kB	8.44 kB	✓
Client `_error` gzip Size	3.23 kB	3.23 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.74 kB	4.74 kB	✓
Client `pages/link` gzip Size	2.02 kB	2.02 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.14 kB	9.14 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	756 kB	756 kB	✓

Click to expand serverless stats

	zeit/next.js canary	Restoration/next.js with-rbx-bulma-pro	Change
Build Duration	16.5s	16.7s	⚠️ +180ms
`node_modules` Size	45.2 MB	45.2 MB	⚠️ +28 B
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70.1 kB	70.1 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.44 kB	8.44 kB	✓
Client `_error` gzip Size	3.23 kB	3.23 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.74 kB	4.74 kB	✓
Client `pages/link` gzip Size	2.02 kB	2.02 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.14 kB	9.14 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	Error getting size	Error getting size	✓
Serverless `pages/link` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	329 kB	329 kB	✓
Serverless `pages/_error` gzip Size	84.2 kB	84.2 kB	⚠️ +1 B
Serverless `pages/routerDirect` Size	Error getting size	Error getting size	✓
Serverless `pages/routerDirect` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/withRouter` Size	Error getting size	Error getting size	✓
Serverless `pages/withRouter` gzip Size	Error getting size	Error getting size	✓
Build Dir Size	1.06 MB	1.06 MB	✓

lfades · 2019-07-03T23:02:29Z

Hi @Restoration , thank you for the PR, I took a look and I like it, there are still some changes required:

Update the readme to focus only in the example, use the readme of other examples as a guide
Fix lint issues in the code using yarn lint-fix or npm run lint-fix
Remove the static folder, we don't need the favicon in this example
Remove the .gitignore file
Remove the changes you did to the root package.json of the repo

lfades · 2019-07-03T23:03:06Z

examples/with-rbx-bulma-pro/package.json

@@ -0,0 +1,16 @@
+{
+  "name": "create-next-example-app",


Suggested change

"name": "create-next-example-app",

"name": "with-rbx-bulma-pro",

lfades · 2019-07-03T23:08:17Z

examples/with-rbx-bulma-pro/pages/about.js

+        <li>Automatic code splitting for faster page loads</li>
+        <li>Simple client-side routing (page based)</li>
+        <li>Webpack-based dev environment which supports Hot Module Replacement (HMR)</li>
+        <li>Able to implement with Express or any other Node.js HTTP server</li>


Suggested change

<li>Able to implement with Express or any other Node.js HTTP server</li>

<li>Serverless support</li>

lfades · 2019-07-03T23:09:09Z

examples/with-rbx-bulma-pro/pages/about.js

+  <Layout>
+    <Section>
+      <Title as='h2'>About</Title>
+      <p>That's exactly what we do with Next.js. Instead of PHP, we build the app with JavaScript and React. Here are some other cool features Next.js brings to the table:</p>


Why does it start like that?, makes no sense to me.

I copied text from getting start guide
I'll fix it

lfades · 2019-07-03T23:11:16Z

examples/with-rbx-bulma-pro/pages/about.js

+      <ul>
+        <li>Server-rendered by default</li>
+        <li>Automatic code splitting for faster page loads</li>
+        <li>Simple client-side routing (page based)</li>


Suggested change

<li>Simple client-side routing (page based)</li>

<li>Filesystem based router, including dynamic routes</li>

lfades · 2019-07-03T23:14:50Z

examples/with-rbx-bulma-pro/pages/contact.js

+const ContactPage = () => (
+  <Layout>
+    <Section>
+      <Title as='h2'>Contact</Title>


Suggested change

<Title as='h2'>Contact</Title>

<Title as='h2'>Contact Form Example</Title>

lfades · 2019-07-03T23:17:00Z

package.json

@@ -107,5 +107,8 @@
  },
  "engines": {
    "node": ">= 8.0.0"
+  },
+  "dependencies": {


Remove this please 🙏

lfades

Update with the changes requested above

github-actions · 2019-07-04T00:45:03Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	Restoration/next.js with-rbx-bulma-pro	Change
Build Duration	14.2s	14s	-194ms
`node_modules` Size	45.2 MB	45.2 MB	-11.1 kB
Total Bundle (main, webpack, commons) Size	210 kB	213 kB	⚠️ +3.36 kB
Total Bundle (main, webpack, commons) gzip Size	68.9 kB	70.1 kB	⚠️ +1.17 kB
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.44 kB	8.44 kB	✓
Client `_error` gzip Size	3.23 kB	3.23 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.74 kB	4.74 kB	✓
Client `pages/link` gzip Size	2.02 kB	2.02 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	24.3 kB	27.6 kB	⚠️ +3.36 kB
Client `main` gzip Size	7.97 kB	9.14 kB	⚠️ +1.17 kB
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	744 kB	756 kB	⚠️ +12.1 kB

Click to expand serverless stats

	zeit/next.js canary	Restoration/next.js with-rbx-bulma-pro	Change
Build Duration	16.2s	17s	⚠️ +832ms
`node_modules` Size	45.2 MB	45.2 MB	-11.1 kB
Total Bundle (main, webpack, commons) Size	210 kB	213 kB	⚠️ +3.36 kB
Total Bundle (main, webpack, commons) gzip Size	68.9 kB	70.1 kB	⚠️ +1.17 kB
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.44 kB	8.44 kB	✓
Client `_error` gzip Size	3.23 kB	3.23 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.74 kB	4.74 kB	✓
Client `pages/link` gzip Size	2.02 kB	2.02 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	24.3 kB	27.6 kB	⚠️ +3.36 kB
Client `main` gzip Size	7.97 kB	9.14 kB	⚠️ +1.17 kB
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	Error getting size	Error getting size	✓
Serverless `pages/link` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	329 kB	329 kB	⚠️ +337 B
Serverless `pages/_error` gzip Size	84.1 kB	84.2 kB	⚠️ +65 B
Serverless `pages/routerDirect` Size	Error getting size	Error getting size	✓
Serverless `pages/routerDirect` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/withRouter` Size	Error getting size	Error getting size	✓
Serverless `pages/withRouter` gzip Size	Error getting size	Error getting size	✓
Build Dir Size	1.05 MB	1.06 MB	⚠️ +12.1 kB

github-actions · 2019-07-04T13:14:19Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	Restoration/next.js with-rbx-bulma-pro	Change
Build Duration	14.5s	14.4s	-111ms
`node_modules` Size	45.7 MB	45.7 MB	⚠️ +28 B
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.9 kB	68.9 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.74 kB	4.74 kB	✓
Client `pages/link` gzip Size	2.02 kB	2.02 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	24.3 kB	24.3 kB	✓
Client `main` gzip Size	7.97 kB	7.97 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	744 kB	744 kB	✓

Click to expand serverless stats

	zeit/next.js canary	Restoration/next.js with-rbx-bulma-pro	Change
Build Duration	16.6s	16.4s	-236ms
`node_modules` Size	45.7 MB	45.7 MB	⚠️ +28 B
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.9 kB	68.9 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.74 kB	4.74 kB	✓
Client `pages/link` gzip Size	2.02 kB	2.02 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	24.3 kB	24.3 kB	✓
Client `main` gzip Size	7.97 kB	7.97 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	Error getting size	Error getting size	✓
Serverless `pages/link` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	329 kB	329 kB	✓
Serverless `pages/_error` gzip Size	84.1 kB	84.1 kB	-2 B
Serverless `pages/routerDirect` Size	Error getting size	Error getting size	✓
Serverless `pages/routerDirect` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/withRouter` Size	Error getting size	Error getting size	✓
Serverless `pages/withRouter` gzip Size	Error getting size	Error getting size	✓
Build Dir Size	1.05 MB	1.05 MB	✓

simakwm · 2019-11-19T20:22:08Z

There is a typo in README.
npm create-next-app --example with-rbx-bulma-pro with-rbx-bulma-pro-app
It should be
npx create-next-app --example with-rbx-bulma-pro with-rbx-bulma-pro-app

Requested [here](#7728 (comment))

lfades · 2019-11-22T05:41:24Z

@simakwm Created #9494 to fix it, next time you can also create a PR and make the change 💯

Requested [here](#7728 (comment))

simakwm · 2019-11-22T12:29:27Z

Yeah, sorry =)

Restoration requested a review from lfades as a code owner July 2, 2019 09:28

Implemented example for rbx and bulma-pro

bfe742e

Added example with rbx and bulma-pro package

Refactor

d0d1c06

Changed double quote to single quote

lfades reviewed Jul 3, 2019

View reviewed changes

package.json Outdated

@@ -107,5 +107,8 @@

},

"engines": {

"node": ">= 8.0.0"

},

"dependencies": {

Copy link

Member

lfades Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this please 🙏

lfades requested changes Jul 3, 2019

View reviewed changes

RyotArch added 3 commits July 3, 2019 17:21

Fixed code

2edb832

Updated README

2e7a65f

Used lint-fix

afb7eea

Merge branch 'canary' into with-rbx-bulma-pro

7feb971

lfades approved these changes Jul 12, 2019

View reviewed changes

lfades merged commit 728fe74 into vercel:canary Jul 12, 2019

lfades pushed a commit that referenced this pull request Nov 22, 2019

[Example] Fix typo in with-rbx-bulma-pro

824a64a

Requested [here](#7728 (comment))

lfades mentioned this pull request Nov 22, 2019

[Example] Fix typo in with-rbx-bulma-pro #9494

Merged

lfades pushed a commit that referenced this pull request Nov 22, 2019

[Example] Fix typo in with-rbx-bulma-pro (#9494)

ca730d7

Requested [here](#7728 (comment))

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented example for rbx and bulma-pro #7728

Implemented example for rbx and bulma-pro #7728

Restoration commented Jul 2, 2019

github-actions bot commented Jul 2, 2019

github-actions bot commented Jul 2, 2019

lfades commented Jul 3, 2019 •

edited

Loading

lfades Jul 3, 2019

lfades Jul 3, 2019 •

edited

Loading

lfades Jul 3, 2019

Restoration Jul 4, 2019 •

edited

Loading

lfades Jul 3, 2019 •

edited

Loading

lfades Jul 3, 2019

lfades Jul 3, 2019

lfades left a comment

github-actions bot commented Jul 4, 2019

github-actions bot commented Jul 4, 2019

simakwm commented Nov 19, 2019

lfades commented Nov 22, 2019

simakwm commented Nov 22, 2019

	"name": "create-next-example-app",
	"name": "with-rbx-bulma-pro",

	<li>Able to implement with Express or any other Node.js HTTP server</li>
	<li>Serverless support</li>

	<li>Simple client-side routing (page based)</li>
	<li>Filesystem based router, including dynamic routes</li>

	<Title as='h2'>Contact</Title>
	<Title as='h2'>Contact Form Example</Title>

Implemented example for rbx and bulma-pro #7728

Implemented example for rbx and bulma-pro #7728

Conversation

Restoration commented Jul 2, 2019

github-actions bot commented Jul 2, 2019

Stats from current PR

github-actions bot commented Jul 2, 2019

Stats from current PR

lfades commented Jul 3, 2019 • edited Loading

lfades Jul 3, 2019

Choose a reason for hiding this comment

lfades Jul 3, 2019 • edited Loading

Choose a reason for hiding this comment

lfades Jul 3, 2019

Choose a reason for hiding this comment

Restoration Jul 4, 2019 • edited Loading

Choose a reason for hiding this comment

lfades Jul 3, 2019 • edited Loading

Choose a reason for hiding this comment

lfades Jul 3, 2019

Choose a reason for hiding this comment

lfades Jul 3, 2019

Choose a reason for hiding this comment

lfades left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 4, 2019

Stats from current PR

github-actions bot commented Jul 4, 2019

Stats from current PR

simakwm commented Nov 19, 2019

lfades commented Nov 22, 2019

simakwm commented Nov 22, 2019

lfades commented Jul 3, 2019 •

edited

Loading

lfades Jul 3, 2019 •

edited

Loading

Restoration Jul 4, 2019 •

edited

Loading

lfades Jul 3, 2019 •

edited

Loading