Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong generation of aria-labelledby in tab navigation #38223

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Fix wrong generation of aria-labelledby in tab navigation #38223

merged 2 commits into from
Mar 14, 2023

Conversation

janbensch
Copy link
Contributor

Fixes wrong autogeneration of aria-labelledby in tab navigation.
Fixes #38222

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

Fixes #38222
@janbensch janbensch requested a review from a team as a code owner March 13, 2023 20:21
@XhmikosR XhmikosR changed the title fixed generation of aria-labelledby in tab navigation Mar 14, 2023
@XhmikosR
Copy link
Member

Thanks for the PR! Good catch, because the test was also wrong so it was harder to spot.

For future reference it seems this was broken in 135b9cd#diff-6090db9da36e79f2e879e6d5232960d82d60af6017a0297d6c500c7cdb5953a1R221
@XhmikosR XhmikosR merged commit e00d06e into twbs:main Mar 14, 2023
@janbensch
Copy link
Contributor Author

Thanks for the quick approval. And sorry that I missed the test case!
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility js v5
3 participants
@janbensch @XhmikosR @julien-deramond