Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: enhance Focus ring example section desc #37772

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 30, 2022

Description

This PR suggests to add a precision in "Helpers > Focus ring > Example" description so that it is easier to see the rendering. IMO :focus is way easier to test out with a simple click instead of having to click on the area and then press "Tab".

I tried a sentence that combines both ideas but feel free to modify it or close the PR if you're not convinced.

Type of changes

  • Doc enhancement

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review December 30, 2022 19:28
@mdo mdo merged commit 4b12084 into main Dec 31, 2022
@mdo mdo deleted the main-jd-docs-focus-ring branch December 31, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants