Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove unnecessary id/aria-labelledby from accordion examples #37766

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Dec 30, 2022

Description

Explicit labelling (which then would also benefit from a role="group" or similar role) is only optional, and not really appropriate just for a cheatsheet

https://www.w3.org/WAI/ARIA/apg/patterns/accordion/

Motivation & Context

Follow-up to #37718

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

https://deploy-preview-37766--twbs-bootstrap.netlify.app/docs/5.3/components/accordion/

Related issues

#37591

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@mdo mdo merged commit 1b39d12 into main Dec 31, 2022
@mdo mdo deleted the patrickhlauke-issue37591-followup branch December 31, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment