Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: standardize usage of <kbd> #37282

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Docs: standardize usage of <kbd> #37282

merged 1 commit into from
Oct 12, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 10, 2022 •
edited
Loading

Description

This PR proposes the standardize the usage of <kbd> along the documentation:

  • <kbd><kbd>Ctrl</kbd> + <kbd>Key</kbd></kbd> when combination of keys
  • <kbd>Key</kbd> for simple keys
  • Don't use full uppercase keys ("TAB" -> "Tab", etc.)

Motivation & Context

Consistency throughout the documentation and use standard name of the keys.

Type of changes

  • Enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly

Live previews

  • Check js/tests/visual/button.html manually

Related issues

N/A
@julien-deramond julien-deramond marked this pull request as ready for review October 10, 2022 19:26
@julien-deramond julien-deramond changed the title Standardize usage of <kbd> in docs Oct 10, 2022
@mdo mdo merged commit 137c932 into main Oct 12, 2022
@mdo mdo deleted the main-jd-uniformize-kbd-in-docs branch October 12, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs v5
2 participants
@julien-deramond @mdo