Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost execute function, being able to handle arguments #36652

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Boost execute function, being able to handle arguments #36652

merged 2 commits into from
Oct 7, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Jun 30, 2022 •
edited
Loading

Micro refactoring of execute function to be able to return results and use given arguments
@GeoSot GeoSot changed the title Boost execute function, being able to use arguments Jul 1, 2022
@GeoSot GeoSot added this to In progress in v5.3.0 via automation Jul 16, 2022
@GeoSot GeoSot force-pushed the gs/ref-execute branch 2 times, most recently from e7d4327 to 0dc9f6b Compare July 19, 2022 14:10
@GeoSot GeoSot force-pushed the gs/ref-execute branch 2 times, most recently from ee8fac5 to 86989e2 Compare September 6, 2022 21:57
@GeoSot GeoSot force-pushed the gs/ref-execute branch 2 times, most recently from 29d427a to 7af8a75 Compare October 3, 2022 22:38
@GeoSot GeoSot marked this pull request as ready for review October 5, 2022 14:10
@GeoSot GeoSot requested a review from a team as a code owner October 5, 2022 14:10
julien-deramond
julien-deramond approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment proposed for a unit test sentence

LGTM! Haven't spotted any regressions, unit test covers the cases 🚀
js/tests/unit/util/index.spec.js Outdated Show resolved Hide resolved
GeoSot and others added 2 commits October 7, 2022 15:21
@GeoSot GeoSot merged commit 4cb046a into main Oct 7, 2022
@GeoSot GeoSot deleted the gs/ref-execute branch October 7, 2022 12:25
This was referenced Jun 7, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
js refactoring v5
2 participants
@GeoSot @julien-deramond