This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Document various potential fallback/double download patterns #536
Milestone
Comments
+1 (very important) |
@aFarkas, @Wilto, @baloneysandwiches, can we have a quick discussion to organize these before heading into the docs? As far as I remember, here are our markup patterns: Mutilated IMG pattern
Empty gif pattern
Anti Double download pattern
IE9 picture pattern
|
I think we should simply just use the predefined markups pattern without describing. In case we have srcset x or srcset w, we simply use the "Anti Double download pattern" and only use <img srcset="img-1.jpg 1x, img-2.jpg 2x" /> And in case of art direction we use the "Mutilated IMG pattern": <picture>
<!--[if IE 9]><video style="display: none;"><![endif]-->
<source srcset="large.jpg" media="(min-width: 1200px)">
<source srcset="small.jpg" >
<!--[if IE 9]></video><![endif]-->
<img class="header-image__img" alt="Image">
</picture> And maybe in the gotcha docs, we can inform people about the "Mutilated IMG pattern" in combination with <picture>
<!--[if IE 9]><video style="display: none;"><![endif]-->
<source srcset="large.jpg 1440w, small.jpg 960w" sizes="(max-width: 1280px) 100vw, 1280px">
<!--[if IE 9]></video><![endif]-->
<img alt="Pictured img without art direction">
</picture> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Into this idea. See: #438.
The text was updated successfully, but these errors were encountered: