-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables behind a @forward aren't configurable through an @import #2772
Labels
specs written
Specs have been written for the feature and at least one implementation passes them
Comments
This was referenced Nov 13, 2019
The proposal has landed! Since it's narrowly scoped and blocking work on migrating existing libraries, I'm going to limit the call for comments to one week unless any major issues get raised. |
jathak
added a commit
to sass/sass-spec
that referenced
this issue
Nov 18, 2019
See sass/sass#2772 [skip dart-sass]
This was referenced Nov 18, 2019
jathak
added a commit
to sass/sass-spec
that referenced
this issue
Nov 20, 2019
See sass/sass#2772 [skip dart-sass]
jathak
added a commit
to sass/sass-spec
that referenced
this issue
Nov 25, 2019
See sass/sass#2772 [skip dart-sass]
Since no one has raised any issues, I'm officially marking this proposal as accepted. |
5 tasks
Closing this out because LibSass is now deprecated and we aren't expecting to add any additional features to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
specs written
Specs have been written for the feature and at least one implementation passes them
If a library like the following:
removes the
lib-
prefix when migrating to the module system, it will add an import-only stylesheet like so to preserve the manually prefixed names for downstream users still using@import
.But this currently breaks downstream stylesheets like:
which compiled to
a { color: green; }
prior to migration anda {color: red; }
after.It seems like this is due to
@import
-style configuration not propagating through a@forward
.The text was updated successfully, but these errors were encountered: