Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selectors imported from .css files extendable #2743

Closed
hab25 opened this issue Sep 16, 2019 · 4 comments
Closed

Make selectors imported from .css files extendable #2743

hab25 opened this issue Sep 16, 2019 · 4 comments

Comments

@hab25
Copy link

hab25 commented Sep 16, 2019

The problem is well explained by the question, and pentzzsolt's answer, here: https://stackoverflow.com/questions/48624359/how-to-extend-a-class-from-a-css-file-in-sass

@hab25 hab25 changed the title Make selectors from imported .css files extendable Sep 16, 2019
nex3 added a commit to sass/sass-spec that referenced this issue Sep 23, 2019
@nex3
Copy link
Contributor

nex3 commented Sep 23, 2019

This does currently work, according to my tests, in both Dart Sass and LibSass. There's not currently a spec for it, which is an oversight; I've just put out sass/sass-spec#1463 to fix that.

@nex3 nex3 closed this as completed Sep 23, 2019
@hab25
Copy link
Author

hab25 commented Sep 23, 2019

@nex3 Dart sass doesn't work for me. Here's a MRE: https://github.com/vinayluzrao/sass-issue-2743

@nex3
Copy link
Contributor

nex3 commented Sep 24, 2019

When you write @import "css-importee.css", you aren't actually importing that CSS; you're writing a plain CSS import. To import a CSS stylesheet, you need to leave off the extension and write @import "css-importee".

nex3 added a commit to sass/sass-spec that referenced this issue Sep 24, 2019
@hab25
Copy link
Author

hab25 commented Sep 24, 2019

Ah I see, thanks a lot for clearing it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants