Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass-convert adds extra line breaks between @include directives #1843

Closed
mixxorz opened this issue Sep 26, 2015 · 4 comments
Closed

sass-convert adds extra line breaks between @include directives #1843

mixxorz opened this issue Sep 26, 2015 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mixxorz
Copy link

mixxorz commented Sep 26, 2015

This:

@include component-one;
@include component-two;
@include component-three;

Turns into this:

@include component-one;

@include component-two;

@include component-three;

This was introduced in sass version 3.4.16. I came across this because I use a Sublime Text 3 plugin called SassBeautify which uses sass-convert to beautify the files. This behaviour cases the plugin to give ugly output. 😞

@chriseppstein chriseppstein added bug Something isn't working help wanted Extra attention is needed labels Oct 7, 2015
@chriseppstein
Copy link

Not a high priority issue for us, but it is a bug. We'd happily accept a patch that addresses this.

@first-developer
Copy link

Hi,
It looks like there is no issue with the sass-convert. However, the plugin SassBeautify use by default the option --unix-newlines when building the final command : https://github.com/badsyntax/SassBeautify/blob/master/SassBeautify.py#L246 .

I'm not sure but if you are on windows, it's normal because that is the behavior wanted in sass-convert code :
https://github.com/sass/sass/blob/stable/lib/sass/exec/sass_convert.rb#L142

I don't know if this option could cause that behavior. If not could you please guide me to the files that handle the actual conversion?

Thanks

@mixxorz
Copy link
Author

mixxorz commented Oct 7, 2015

When I was testing the behavior before I submitted this issue, I wasn't using the --unix-newlines option. I am on a Mac though. Does it not happen on Windows?

@srawlins
Copy link

srawlins commented Oct 7, 2015

I don't think this has to do with unix newlines. It probably started when #1697 was merged.

Addisonbean added a commit to Addisonbean/sass that referenced this issue Jul 1, 2016
Addisonbean added a commit to Addisonbean/sass that referenced this issue Jul 1, 2016
Addisonbean added a commit to Addisonbean/sass that referenced this issue Jul 9, 2016
nex3 pushed a commit that referenced this issue Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
4 participants