Update use-data-table.ts #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to decouple the useEffect of server side sorting with the useEffect that request page, and per_page. Your current implement doesn't send per_page when the table loads. This is necessarily when geting the first page from the server.
|
@jpainam is attempting to deploy a commit to the sadmann7 Team on Vercel. A member of the Team first needs to authorize it. |
|
sorry didn't notice this pr thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to decouple the useEffect of server side sorting with the useEffect that sends
page, andper_page.Your current implement doesn't send per_page when the table loads. This is necessarily when geting the first page from the server.
No per_pagein the first run