Project: merge basic and advanced forms #11169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Feb 29, 2024
| @@ -84,7 +83,9 @@ | |||
| ), | |||
| re_path( | |||
| r"^(?P<project_slug>[-\w]+)/advanced/$", | |||
| ProjectAdvancedUpdate.as_view(), | |||
| login_required( | |||
| RedirectView.as_view(pattern_name="projects_edit", permanent=True), | |||
There was a problem hiding this comment.
Suggested change
| RedirectView.as_view(pattern_name="projects_edit", permanent=True), | |
| RedirectView.as_view(pattern_name="projects_edit"), |
Just in case we want to use /advanced/ URL for a different thing.
There was a problem hiding this comment.
Good question. I lean slightly towards non-permanent just because it won't be a heavily used redirect anyways. I don't see us reusing the URL either though, so permanent does seem safe.
| @@ -251,6 +251,7 @@ class PublicProjectMixin(ProjectMixin): | |||
| "/projects/pip/badge/": {"status_code": 200}, | |||
| "/projects/invalid_slug/": {"status_code": 302}, | |||
| "/projects/pip/search/": {"status_code": 302}, | |||
| "/dashboard/pip/advanced/": {"status_code": 301}, | |||
There was a problem hiding this comment.
Suggested change
| "/dashboard/pip/advanced/": {"status_code": 301}, | |
| "/dashboard/pip/advanced/": {"status_code": 302}, |
stsewd
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Feb 29, 2024
stsewd
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Feb 29, 2024
* Project: merge basic and advanced forms Matches readthedocs/readthedocs.org#11169 * Update URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still missing checking how this looks on ext-theme.
Closes #11084