Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 458: Mark as Accepted #1306

Merged
merged 1 commit into from
Feb 15, 2020
Merged

PEP 458: Mark as Accepted #1306

merged 1 commit into from
Feb 15, 2020

Conversation

ncoghlan
Copy link
Contributor

No description provided.

@ncoghlan
Copy link
Contributor Author

@dstufft is away from convenient GitHub access at the moment, so I'm updating this as per his Discourse post.
@ncoghlan ncoghlan merged commit 4751318 into python:master Feb 15, 2020
lukpueh added a commit to lukpueh/tuf that referenced this pull request Feb 18, 2020
@lukpueh
Revise requirements files again
1a47650 
Follows up on theupdateframework#978, which had the following problems:
- too many requirements files (cc @trishankatdatadog ;)
- used custom tooling around pip-compile, which prevented
  Dependabot from updating all files, because Dependabot "shells
  out" to pip-compile, making assumptions about the format of the
  compiled files, that we didn't meet.

This commit restructures the requirements files, choosing a much
simpler approach:

- Merges requirements-tox.txt and requirements-test.txt. The
  separation was semantically correct but operationally irrelevant.
- Removes the hashed requirements file, which doesn't add much
  security, especially with PEP 458 on the way (see python/peps#1306),
  but extra maintenance (see note about requirements.txt in theupdateframework#978).
- Removes the shell script that combined the results of pip-compile
  for all supported Python versions and instead pip-compiles for
  one Python version only. See comments about conditional transitive
  dependencies in requirements.txt in this PR for details.
@lukpueh lukpueh mentioned this pull request Feb 18, 2020
Merged
3 tasks
lukpueh added a commit to lukpueh/tuf that referenced this pull request Feb 18, 2020
@lukpueh
Revise requirements files again
fdc85f8 
Follows up on theupdateframework#978, which had the following problems:
- too many requirements files (cc @trishankatdatadog ;)
- used custom tooling around pip-compile, which prevented
  Dependabot from updating all files, because Dependabot "shells
  out" to pip-compile, making assumptions about the format of the
  compiled files, that we didn't meet.

This commit restructures the requirements files, choosing a much
simpler approach:

- Merges requirements-tox.txt and requirements-test.txt. The
  separation was semantically correct but operationally irrelevant.
- Removes the hashed requirements file, which doesn't add much
  security, especially with PEP 458 on the way (see python/peps#1306),
  but extra maintenance (see note about requirements.txt in theupdateframework#978).
- Removes the shell script that combined the results of pip-compile
  for all supported Python versions and instead pip-compiles for
  one Python version only. See comments about conditional transitive
  dependencies in requirements.txt in this PR for details.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh added a commit to lukpueh/tuf that referenced this pull request Feb 18, 2020
@lukpueh
Revise requirements files again
730e4d8 
Follows up on theupdateframework#978, which had the following problems:
- too many requirements files (cc @trishankatdatadog ;)
- used extra tooling around pip-compile that
  - didn't take into account requirement markers (see comments
    in requirements.txt in this commit), and
  - confused Dependabot, which expects the hashed requirements
    file in a certain format, as pip-compile would generate it
    without custom tooling (see theupdateframework#979).

This commit restructures the requirements files as follows:

- Merges requirements-tox.txt and requirements-test.txt. The
  separation was semantically correct but operationally irrelevant.
- Removes the hashed requirements file, which doesn't add much
  security, especially with PEP 458 on the way (see python/peps#1306),
  but extra maintenance (see notes about requirements.txt in theupdateframework#978
  and about Dependabot above)
- Manually adds environment markers to requirements-pinned.txt (see
  comments in requirements.txt in this commit).

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
mnm678 pushed a commit to mnm678/peps that referenced this pull request Oct 22, 2020
@ncoghlan @mnm678
PEP 458: Mark as Accepted (python#1306)
86271f3
@di di mentioned this pull request Feb 1, 2022
Open
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed
2 participants
@ncoghlan @the-knights-who-say-ni