Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clones of assertFloatsAreIdentical() are scattered across the CPython tests:
cpython/Lib/test/test_complex.py
Line 74 in d8f8243
cpython/Lib/test/test_cmath.py
Line 68 in d8f8243
cpython/Lib/test/test_float.py
Line 1069 in d8f8243
cpython/Lib/test/test_capi/test_getargs.py
Line 440 in d8f8243
Maybe it's worth to have a dedicated check?
Or a special kwarg for the assertEqual method, to workaround NAN and -0.0 values for floats/complexes.
NAN
-0.0
Edit:
Or at least some support from Lib/test/support... I was adding similar helper yet in another test file and that looks odd.
Numpy has numpy.testing.assert_equal():
>>> np.testing.assert_equal([0.0], [+0.0]) >>> np.testing.assert_equal([0.0], [-0.0]) Traceback (most recent call last): ... AssertionError: Items are not equal: item=0 ACTUAL: 0.0 DESIRED: -0.0 >>> np.testing.assert_equal([np.nan], [np.nan]) >>> np.testing.assert_equal([0.0], [np.nan]) Traceback (most recent call last): ... AssertionError: Items are not equal: item=0 ACTUAL: 0.0 DESIRED: nan
This is a minor feature, which does not need previous discussion elsewhere
No response
The text was updated successfully, but these errors were encountered:
pythongh-121039: add Floats/ComplexesAreIdenticalMixin to test.suppor…
d10eef8
…t.testcase
pr is ready: #121071 (it implements the last option: methods added to test.support)
Feature or enhancement
Proposal:
Clones of assertFloatsAreIdentical() are scattered across the CPython tests:
cpython/Lib/test/test_complex.py
Line 74 in d8f8243
cpython/Lib/test/test_cmath.py
Line 68 in d8f8243
cpython/Lib/test/test_float.py
Line 1069 in d8f8243
cpython/Lib/test/test_capi/test_getargs.py
Line 440 in d8f8243
Maybe it's worth to have a dedicated check?
Or a special kwarg for the assertEqual method, to workaround
NAN
and-0.0
values for floats/complexes.Edit:
Or at least some support from Lib/test/support... I was adding similar helper yet in another test file and that looks odd.
Numpy has numpy.testing.assert_equal():
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
The text was updated successfully, but these errors were encountered: