This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
chore: Cleanup test scripts #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmelberg-okta
commented
Sep 28, 2018
| @@ -8,19 +8,18 @@ | |||
| "dist" | |||
| ], | |||
| "scripts": { | |||
| "build:dependencies": "yarn ngc && cd test/e2e/harness && yarn install", | |||
There was a problem hiding this comment.
For context - we previously ran yarn pack to create a *.tgz of our @okta/okta-angular package, then would add it directly to our test-harness via yarn add (npm install --save).
This is unnecessary, as we can reference the package.json in the library via the relative install path (shown here).
| @@ -27,7 +27,7 @@ | |||
| "build:test": "rimraf e2e/dist && babel e2e/ -d e2e/dist", | |||
| "kill:port": "kill -9 $(lsof -t -i:8080 -sTCP:LISTEN) || true", | |||
| "pretest": "yarn kill:port && ./node_modules/.bin/webdriver-manager update --gecko false && yarn build:test", | |||
| "wait:server": "yarn start & ./node_modules/.bin/wait-on http://localhost:8080", | |||
| "wait:server": "BROWSER=none yarn start & ./node_modules/.bin/wait-on http://localhost:8080", | |||
There was a problem hiding this comment.
When running end-to-end tests in React, we're now telling the dev server to not open the browser when it loads.
| "build": "rimraf dist/ && cross-env NODE_ENV=production webpack --config webpack.config.js --output-library-target=umd -p", | ||
| "build:harness": "yarn --cwd test/e2e/harness install", | ||
| "build:package-info": "node ../../util/write-package-info.js . src/packageInfo.js", | ||
| "kill:port": "kill -9 $(lsof -t -i:8080 -sTCP:LISTEN) || true", |
There was a problem hiding this comment.
TODO: We're closing the port (if open) before calling our tests. This means that there is a chance the dev server is still running once they finish.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unifies the
package.jsontest script names for every package. This will provide developers to easily call one of the following:This PR is broken into the following commits:
ab78894- Adds eslint toyarn testfor React package.4189e59- Removedyarn packand file install from test-harness in Angular package.f202fef- Unify remaining package test scripts into format noted above.Reviewers